Remove obsolete DataFormats headers

[perrotta]

PR description:

The following DataFormats headers are already marked as obsolete, and since a while never included in CMSSW code:

DataFormats/BTauReco/interface/JetTracksAssociation.h
DataFormats/JetReco/interface/BasicJetfwd.h
DataFormats/JetReco/interface/CaloJetfwd.h
DataFormats/JetReco/interface/GenJetfwd.h
DataFormats/JetReco/interface/GenericJetfwd.h
DataFormats/JetReco/interface/PFJetfwd.h

They are also giving header inconsistency warnings in the code checks: removing them will silence those warnings

PR validation:

It builds

[perrotta]

@smuzaffar

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26855/9891

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

DataFormats/BTauReco
DataFormats/JetReco

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jdamgov, @TaiSakuma, @rappoccio, @JyothsnaKomaragiri, @ahinzmann, @smoortga, @acaudron, @nhanvtran, @rovere, @HeinerTholen, @jdolen, @mverzett, @gkasieczka, @clelange, @schoef, @ferencek, @mariadalfonso, @pvmulder, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/377/console Started: 2019/05/21 15:33

[cmsbuild]

+1
Tested at: 28b5814
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-674bde/377/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
982c595
c7ba9c0
a08d291
1399b3d
a45e57e
8f3b02d
1dc1ac1
9d1566e
a6b913f
05cc4e1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26855/377/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26855/377/git-merge-result

[cmsbuild]

Comparison job queued.

[smuzaffar]

thanks @perrotta for the cleanup

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-674bde/377/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2541 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3206828
• DQMHistoTests: Total failures: 8155
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3198339
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• Technical: just removed unused headers
• Jenkins tests show the very same differences in outputs with the baseline as for updating GT and BeamSpot for 2021 relvals #26828, whose commits were also included in these tests: I don't think we should waste time and resources in re-running the tests here because of it, given that this PR is rather trivial

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

@perrotta thanks