Fix file path forgotten after 2019-->2021 migration (XML geometry) #26856
Conversation
|
type bugfix |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26856/9893
|
|
A new Pull Request was created by @boudoul (boudoul) for master. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -275,7 +275,7 @@ | |||
| 'Geometry/EcalSimData/data/ESProdCuts.xml', | |||
| 'Geometry/TrackerSimData/data/PhaseI/trackerProdCuts.xml', | |||
| 'Geometry/TrackerSimData/data/trackerProdCutsBEAM.xml', | |||
| 'Geometry/MuonSimData/data/2021/muonProdCuts.xml', | |||
| 'Geometry/MuonSimData/data/2021/v1/muonProdCuts.xml', | |||
There was a problem hiding this comment.
@boudoul - shouldn't it be Geometry/MuonSimData/data/muonProdCuts/2021/v1/muonProdCuts.xml?
There was a problem hiding this comment.
Please, see rule No5 in https://github.com/cms-sw/cms-sw.github.io/blob/master/cms_coding_rules.md
There was a problem hiding this comment.
hi @ianna .. mmh you are suggesting to add yet another subdirectory to https://github.com/cms-sw/cmssw/tree/master/Geometry/MuonSimData/data ? Geometry/MuonSimData/data/muonProdCuts doesn't exist ...
There was a problem hiding this comment.
sorry, it's not me, the CMS coding rules do :-)
|
-1 |
cmsbuild
added
code-checks-pending
geometry-pending
and removed
code-checks-approved
geometry-rejected
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26856/9895
|
|
Pull request #26856 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
+upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
+1 |
as mentioned in this Issue : #26771 (thanks @christopheralanwest , and also @abdoulline , @mazarkin for noticing ) there was a mistake introdcued after the 2019-->2021 migration , a fileptah was incorrect - This PR is fixing this issue.
PR validation:
It should not affect any std WF (where the geometry is read via the DB) , but I ran few events calling explicitely the 2021 XML :
runTheMatrix.py -l 11623 --command '--geometry Extended2021'