Manage plugin factory plugins with unique_ptr in Alignment

[makortel]

PR description:

This PR is a preparatory step to change PluginFactory to return std::unique_ptr.

In addition use range-for, and more unique_ptr in AlignmentProducerBase.

PR validation:

Code compiles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26863/9899

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Alignment/CommonAlignmentAlgorithm
Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentProducer
Alignment/ReferenceTrajectories

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/391/console Started: 2019/05/21 21:40

[makortel]

This vector could be also done with std::shared_ptr, which would avoid defining the custom copy constructor (with the cloning), and would keep the TrajectoryFactoryBase objects shared between the copies of CombinedTrajectoryFactory.

[fabiocos]

@makortel are you satisfied with this PR in its present status or are you planning further update?

[makortel]

I'm satisfied, just wanted to say that it is possible to also share the TrajectoryFactoryBase objects if that is needed. So I'm not planning updates.

[cmsbuild]

-1

Tested at: f1a13f6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-736239/391/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26863/9922

• This PR adds an extra 32KB to repository

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/423/console Started: 2019/05/22 15:56

[cmsbuild]

Pull request #26863 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please check and sign again.

[cmsbuild]

+1
Tested at: 59c5084
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-736239/423/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-736239/423/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3206828
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3206493
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1