Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily revert "Add vertex resolutions and pulls vs x,y,z positions in tracking DQM" #26878

Merged
merged 1 commit into from May 22, 2019

Conversation

fabiocos
Copy link
Contributor

Reverts #26822

Following investigations of crashes in the IB after the integration of #26822

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26878/9914

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorClient

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @mtosi, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test workflow 136.831

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/409/console Started: 2019/05/22 10:17

@fabiocos
Copy link
Contributor Author

@mmusich indeed in a standalone test of mine this revert fixes the reproducible crash of 136.831 . I integrate the revert for the next IB, and we may come back to this code as soon as the fix is available

@fabiocos fabiocos changed the title Revert "Add vertex resolutions and pulls vs x,y,z positions in tracking DQM" Temporarily revert "Add vertex resolutions and pulls vs x,y,z positions in tracking DQM" May 22, 2019
@fabiocos
Copy link
Contributor Author

+1

@fabiocos
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 18de5b8 into master May 22, 2019
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62aa5f/409/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3206828
  • DQMHistoTests: Total failures: 105
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3206389
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -32296.044 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 250202.181,... ): -1468.002 KiB OfflinePV/Resolution
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@smuzaffar smuzaffar deleted the revert-26822-addResolutionsVsXYZ branch May 31, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants