Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Photos options (7_1_X) #26886

Merged
merged 7 commits into from Jun 6, 2019
Merged

Conversation

mseidel42
Copy link
Contributor

PR description:

Backport of #26853

Needs cms-sw/cmsdist#4997

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_7_1_X.

It involves the following packages:

GeneratorInterface/PhotosInterface

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@efeyazgan
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/415/console Started: 2019/05/22 14:11

@alberto-sanchez
Copy link
Member

you shuld use:

please test with cms-sw/cmsdist#4997

@cmsbuild
Copy link
Contributor

There was an issue with git-cms-merge-topic you can see the log here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26886/415/git-merge-result

@alberto-sanchez
Copy link
Member

please test with cms-sw/cmsdist#4997

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#4997
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/437/console Started: 2019/05/23 04:40

@cmsbuild
Copy link
Contributor

-1

  • Build:

I found compilation error when building:

creating the shared library /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc6_amd64_gcc481/external/evtgen/1.3.0-cms13/evtgen/1.3.0/lib/libEvtGenExternal.so
g++ -O2 -Wall -pthread -fPIC  ../tmp_ext/EvtGenExternal/EvtExternalGenFactory.o ../tmp_ext/EvtGenExternal/EvtPhotosEngine.o ../tmp_ext/EvtGenExternal/EvtExternalGenList.o ../tmp_ext/EvtGenExternal/EvtPHOTOS.o ../tmp_ext/EvtGenExternal/EvtPythia.o ../tmp_ext/EvtGenExternal/EvtPythiaEngine.o ../tmp_ext/EvtGenExternal/EvtPythia6CommandConverter.o ../tmp_ext/EvtGenExternal/EvtTauolaEngine.o ../tmp_ext/EvtGenExternal/EvtTauola.o -o /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc6_amd64_gcc481/external/evtgen/1.3.0-cms13/evtgen/1.3.0/lib/libEvtGenExternal.so -shared -Wl,-soname,libEvtGenExternal.so -lgfortran -lgfortranbegin \
	-L/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc481/external/hepmc/2.06.07-ddibom/lib -lHepMC -L/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc481/external/photospp/3.61/lib -lPhotosCxxInterface -lPhotosFortran -L/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc481/external/tauolapp/1.1.4-ddibom13/lib -lTauolaCxxInterface -lTauolaFortran -L/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc481/external/pythia8/226-ddibom6/lib -lpythia8 -L/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc6_amd64_gcc481/external/evtgen/1.3.0-cms13/evtgen/1.3.0/lib -lEvtGen
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lPhotosCxxInterface
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lPhotosFortran
collect2: error: ld returned 1 exit status
make[1]: *** [/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc6_amd64_gcc481/external/evtgen/1.3.0-cms13/evtgen/1.3.0/lib/libEvtGenExternal.so] Error 1
rm ../tmp_ext/EvtGenExternal/EvtTauolaEngine.mk ../tmp_ext/EvtGenExternal/EvtPhotosEngine.mk ../tmp_ext/EvtGenExternal/EvtTauola.mk ../tmp_ext/EvtGenExternal/EvtPythiaEngine.mk ../tmp_ext/EvtGenExternal/EvtPHOTOS.mk ../tmp_ext/EvtGenExternal/EvtPythia.mk ../tmp_ext/EvtGenExternal/EvtPythia6CommandConverter.mk ../tmp_ext/EvtGenExternal/EvtExternalGenFactory.mk ../tmp_ext/EvtGenExternal/EvtExternalGenList.mk
make[1]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc6_amd64_gcc481/external/evtgen/1.3.0-cms13/evtgen/1.3.0/src'
make: *** [libext_shared] Error 2
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.B3tGg2 (%build)


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4055d/437/summary.html

@cmsbuild
Copy link
Contributor

There was an issue with git-cms-merge-topic you can see the log here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26886/456/git-merge-result

@mrodozov
Copy link
Contributor

please test cms-sw/cmsdist#4997
lets try one last time and then I'll have a look

@mseidel42
Copy link
Contributor Author

It looked like a github issue?

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2879bb/456/git-merge-result:

+ git cms-merge-topic -u cms-sw:26886
Attention: git is unable to access GitHub over https, switching to ssh.
Cloning into '/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_7_1_X_2019-05-21-1100/src'...
Switched to a new branch 'from-CMSSW_7_1_X_2019-05-21-1100'
From .
 * [new ref]                    -> merge-attempt
fatal: unable to access 'https://github.com/cms-sw/cmssw.git/': error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version
fatal: unable to access 'https://github.com/cms-sw/cmssw.git/': error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

@mrodozov
Copy link
Contributor

please test with cms-sw/cmsdist#4997

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#4997
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/485/console Started: 2019/05/24 11:17
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/493/console Started: 2019/05/24 14:54

@cmsbuild
Copy link
Contributor

There was an issue with git-cms-merge-topic you can see the log here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26886/485/git-merge-result

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4055d/493/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 682535
  • DQMHistoTests: Total failures: 3327
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 678834
  • DQMHistoTests: Total skipped: 374
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
  • Checked 44 log files, 4 edm output root files, 11 DQM output files

@efeyazgan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

+1

@cmsbuild cmsbuild merged commit 5c96758 into cms-sw:CMSSW_7_1_X Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants