Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport HTXS Stage1.1 producer and filter to 93X #26904

Merged
merged 1 commit into from Jul 2, 2019

Conversation

janekbechtel
Copy link
Contributor

PR description:

This is a backport of the combination of two PRs
#26724 by @yhaddad
and
#26891

It backports the possibility to classifiy events based on their simplified template cross-section store during the GEN-SIM creation, and filter based on this output. It will be needed for this version for an upcoming MC production.

PR validation:

The standard tests and a MC production using the new filter have been run as tests.

if this PR is a backport please specify the original PR:

#26724
and
#26891

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @janekbechtel (Janek Bechtel) for CMSSW_9_3_X.

It involves the following packages:

GeneratorInterface/GenFilters
GeneratorInterface/RivetInterface
SimDataFormats/HTXS

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @kpedro88 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/454/console Started: 2019/05/23 17:19

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bca0a4/454/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 219
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624052
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@efeyazgan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @kpedro88 (and backports should be raised in the release meeting by the corresponding L2)

@janekbechtel
Copy link
Contributor Author

The two commits that this commit is backporting (#26724) and (#26891) have now been merged and closed, what is the status for this PR? We will need it soon in 93X

@Andrej-CMS
Copy link
Contributor

Dear @kpedro88 , @ALL
Could you please have a look and sign the PR if everything is alright?
We need this filter in production for simplified template cross section samples.
Kind regards,

Andrej

@fabiocos
Copy link
Contributor

fabiocos commented Jul 2, 2019

@Andrej-CMS as previously discussed we were waiting for a practical use for this backport

@Andrej-CMS
Copy link
Contributor

Hi @fabiocos
Do you mean, that you want us to submit a test sample with the 10_2_X setup to verify that this works also in production?

https://cms-pdmv.cern.ch/mcm/requests?prepid=HIG-RunIIFall18wmLHEGS-02102

@fabiocos
Copy link
Contributor

fabiocos commented Jul 2, 2019

@Andrej-CMS @efeyazgan @qliphy this is changing the event content if invoked in production, am I correct/ Will this be used for dedicated samples?

@Andrej-CMS
Copy link
Contributor

@Andrej-CMS @efeyazgan @qliphy
These are filters that are based on the classification of events in simplified template cross sections (STXS). For each of the categories in the STXS, we will use the filter to produce a filtered sample such that only events in this category pass the filter. The enrichment in categories is important to have enough statistics in MVA training for each analysis.

You can find the definitions of the categories for STXS in the link below:

https://gitlab.cern.ch/LHCHIGGSXS/LHCHXSWG2/STXS/Classification/blob/master/HiggsTemplateCrossSections.h#L52

@fabiocos
Copy link
Contributor

fabiocos commented Jul 2, 2019

@Andrej-CMS I am speaking of the producer that is storing an object in the event. This is not a persistent object, am I correct?

@Andrej-CMS
Copy link
Contributor

@fabiocos
yes that is correct, the object is not persistent. It's only used for the filtering and is not kept in further steps.

@fabiocos
Copy link
Contributor

fabiocos commented Jul 2, 2019

+1

@cmsbuild cmsbuild merged commit d0f86f6 into cms-sw:CMSSW_9_3_X Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants