Herwig7 fix seg fault102

[Andrej-CMS]

Backport of #26905

[cmsbuild]

A new Pull Request was created by @Andrej-CMS for CMSSW_10_2_X.

It involves the following packages:

Configuration/Generator
GeneratorInterface/Herwig7Interface

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Herwig7 fix seg fault master #26905

[qliphy]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/475/console Started: 2019/05/24 02:07

[cmsbuild]

+1
Tested at: b9349a2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1230a/475/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1230a/475/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007440
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007248
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@efeyazgan @qliphy @Andrej-CMS which is the level of validation of this fix? Before putting it in production I think we need to ensure it is behaving correctly in master, what was done so far about this, besides checking that it runs smoothly from the technical point fo view?

[Andrej-CMS]

@efeyazgan @qliphy
could you please test again after the update of WF 535

[qliphy]

please test workflow 535

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/551/console Started: 2019/05/28 12:41

[cmsbuild]

+1
Tested at: 0ded259
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1230a/551/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1230a/551/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-a1230a/535.0_TTbar_13TeV_Pow_herwig7+TTbar_13TeV_Pow_herwig7+HARVESTGEN

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007468
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007275
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[qliphy]

Although as shown with "comparisons for the following workflows were not done due to missing matrix map:", Andrej has already checked locally, as mentioned in #26905

[qliphy]

+1

[Andrej-CMS]

@qliphy
yes, I made DQM comparisons as mentioned in #26905 (comment)

[prebello]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1