Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RECO] Remove ROOT::Math dict which are unused #26931

Merged
merged 1 commit into from May 25, 2019
Merged

[RECO] Remove ROOT::Math dict which are unused #26931

merged 1 commit into from May 25, 2019

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented May 24, 2019

PR description:

PR #26883 replaced the usage of ROOT::Math::* with explicit dictionaries for

  <class pattern="std::vector<ROOT::Math::SMatrix<*>>" />
  <class pattern="std::vector<ROOT::Math::MatRepStd<*>>" />
  <class pattern="std::vector<ROOT::Math::RowOffsets<*>>" />
  <class pattern="std::vector<ROOT::Math::SVector<*>>" />

rootcling complains that 3 of these are not used.

>> Building LCG reflex dict from header file src/DataFormats/Math/src/classes.h
  Warning: Unused class rule: std::vector<ROOT::Math::SVector<*>>
   Warning: Unused class rule: std::vector<ROOT::Math::RowOffsets<*>>
   Warning: Unused class rule: std::vector<ROOT::Math::MatRepStd<*>>

This PR proposes to drop these to avoid the warnings.

PR validation:

Local compilation does not show these warnings any more.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26931/9973

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2019

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/Math

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Comparison job queued.

smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request May 24, 2019
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8b8f8/500/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3206856
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3206521
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor Author

@slava77 , @perrotta and @fabiocos , we need to get in to avoid the build errors caused by #26883 . We did not see the errors in pr tests as the DataFormatsMath library was available from release area. In full build this resulted in build errors.

@slava77
Copy link
Contributor

slava77 commented May 25, 2019

+1

for #26931 384b996

  • technical
  • jenkins tests pass
    • the build now does not show the compilation warnings

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8fc7223 into cms-sw:master May 25, 2019
smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants