New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take SeedGeneratorFromRegionHits constructor arguments as unique_ptrs #26939
Take SeedGeneratorFromRegionHits constructor arguments as unique_ptrs #26939
Conversation
The code-checks are being triggered in jenkins. |
@@ -45,7 +45,7 @@ class SeedFilter { | |||
void seeds(edm::Event&, const edm::EventSetup&, const reco::SuperClusterRef &, TrajectorySeedCollection *); | |||
|
|||
private: | |||
SeedGeneratorFromRegionHits *combinatorialSeedGenerator; | |||
std::unique_ptr<SeedGeneratorFromRegionHits> combinatorialSeedGenerator; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In retrospect this change should have been part of #26858.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26939/9981
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: RecoEgamma/EgammaElectronAlgos @perrotta, @Martin-Grunewald, @cmsbuild, @fwyzard, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a preparatory step to change PluginFactory to return
std::unique_ptr
.(should be the last PR before making the change on the framework side, unless I've missed something)
PR validation:
Code compiles.