Added Consumes to SteppingHelixPropagatorESProducer

[Dr15Jones]

PR description:

Added consumes to SteppingHelixPropagatorESProducer.
Switched to using ESGetTokens.
Ran the code formatting tool.

PR validation:

The code compiles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26994/10050

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

TrackPropagation/SteppingHelixPropagator

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ebrondol, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/586/console Started: 2019/05/29 16:18

[makortel]

Part of #26748.

[cmsbuild]

+1
Tested at: bc835cd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ea05e/586/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ea05e/586/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5250 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3210728
• DQMHistoTests: Total failures: 21427
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3188967
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.774 KiB( 32 files compared)
• DQMHistoSizes: changed ( 25202.0 ): -0.182 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.592 KiB SiStrip/MechanicalView
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

DQMHistoTests: Total failures: 21427

I was expecting no differences.
It looks like something random is happening in the workflows with mixing.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/602/console Started: 2019/05/30 14:17

[cmsbuild]

+1
Tested at: bc835cd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ea05e/602/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ea05e/602/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3210678
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3210343
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #26994 bc835cd

• technical
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1