correct missing commas in dflt initializations for ghostTrack in IPProducer

[slava77]

This is a follow up to #26913 (comment)

@ferencek

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27000/10056

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

RecoBTag/ImpactParameter

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/591/console Started: 2019/05/29 19:49

[cmsbuild]

+1
Tested at: de52341
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f0039/591/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f0039/591/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3210728
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3210393
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

as expected, in a few cases the ghostTrack tag infos moved from -2 to 0.
E.g. in Run2018A EGamma wf 136.85

[slava77]

+1

for #27000 de52341

• differences observed in the jenkins tests are as expected: in some rare cases where the defaults are not reset the values are now at 0 instead of -2

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@slava77 this looks a genuine bug fix that I assume we would like to port to 10_6_X, am I correct?

[fabiocos]

+1

[slava77]

@slava77 this looks a genuine bug fix that I assume we would like to port to 10_6_X, am I correct?

I do not really see a reason for a backport.
From #26913 (comment)

The ghost track feature is not really in active use which probably explains why this went unnoticed all this time.

[fabiocos]

@slava77 ok, in this case I agree, although strictly speaking it remains a bug