Modernize HcalDbProducer

[makortel]

PR description:

This PR modernizes HcalDbProducer (as part of #26748) by

• moving the contents of the header to the source file
• using ESGetToken
• replacing repeated patterns with generic functions that take advantage of the ESGetToken declarations

I took the liberty of modifying a bit the format of the optional printouts for some products in order to keep the overall structure generic (and thus deducing information from types as much as possible).

PR validation:

Limited matrix runs, no changes expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[makortel]

@Dr15Jones in case you're interested to take a look

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27014/10082

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CalibCalorimetry/HcalPlugins

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/621/console Started: 2019/05/30 23:22

[kpedro88]

@abdoulline FYI

[cmsbuild]

+1
Tested at: bce56e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7b606/621/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7b606/621/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3210678
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3210343
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1