Running code-format for reconstruction #27069

cmsbuild · 2019-06-03T03:41:03Z

Applying code-format for CMSSW category reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/345//console

cms-bot has successfully run the following:

scram build code-checks-all
scram build code-format-all
scram build

cmsbuild · 2019-06-03T03:41:04Z

please test

cmsbuild · 2019-06-03T03:41:41Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-03T03:47:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27069/10155

This PR adds an extra 8KB to repository

cmsbuild · 2019-06-03T03:48:37Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/707/console Started: 2019/06/03 05:54

cmsbuild · 2019-06-03T03:48:38Z

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/EcalRecHit
DataFormats/JetReco
DataFormats/ParticleFlowCandidate
DataFormats/RecoCandidate
DataFormats/TrackReco
DataFormats/TrackerRecHit2D
RecoParticleFlow/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @hatakeyamak, @rappoccio, @argiro, @seemasharmafnal, @mmarionncern, @makortel, @lgray, @jdolen, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @ahinzmann, @cbernet, @gpetruc, @mariadalfonso, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-06-03T15:47:29Z

-1

Tested at: 0f65aee

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Running code-format for analysis #27033
@cms-sw: Running code-format for analysis
Running code-format for analysis #27038
@cms-sw: Running code-format for analysis
Running code-format for simulation #26990
@cms-sw: Running code-format for simulation
Running code-format for analysis #27037
@cms-sw: Running code-format for analysis
Running code-format for analysis #27034
@cms-sw: Running code-format for analysis
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17128e/707/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17128e/707/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17128e/707/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Running code-format for analysis #27033
@cms-sw: Running code-format for analysis
Running code-format for analysis #27038
@cms-sw: Running code-format for analysis
Running code-format for simulation #26990
@cms-sw: Running code-format for simulation
Running code-format for analysis #27037
@cms-sw: Running code-format for analysis
Running code-format for analysis #27034
@cms-sw: Running code-format for analysis
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17128e/707/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17128e/707/git-merge-result

cmsbuild · 2019-06-03T15:47:32Z

Comparison job queued.

slava77

a few cases that could be addressed later

slava77 · 2019-06-03T17:18:45Z

DataFormats/EcalRecHit/interface/EcalUncalibratedRecHit.h

+  float jitter_;          //< Reconstructed time jitter
+  float chi2_;            //< Chi2 of the pulse
+  float OOTamplitudes_
+      [EcalDataFrame::MAXSAMPLES];  //< Out-Of-Time reconstructed amplitude, one for each active BX, from readout sample 0 to 9


move the comment instead of breaking the code line

slava77 · 2019-06-03T17:20:40Z

DataFormats/JetReco/src/Jet.cc

-  const double CaloPoint::depth = 0.1; // one for all relative depth of the reference point between ECAL begin and HCAL end
-  const double CaloPoint::R_BARREL = (1.-depth)*143.+depth*407.;
+  const double CaloPoint::depth =
+      0.1;  // one for all relative depth of the reference point between ECAL begin and HCAL end


move the comment; not break code line

slava77 · 2019-06-03T17:25:01Z

DataFormats/TrackReco/interface/TrackBase.h

    /// track quality
    uint8_t quality_;

    /// number of loops made during the building of the trajectory of a looper particle
-    signed char nLoops_; // I use signed char because I don't expect more than 128 loops and I could use a negative value for a special purpose.
+    signed char
+        nLoops_;  // I use signed char because I don't expect more than 128 loops and I could use a negative value for a special purpose.


move the comment

cmsbuild · 2019-06-03T18:48:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17128e/707/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3210678
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3210343
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2019-06-03T19:46:33Z

+1

for #27069 0f65aee

technical
jenkins tests pass

cmsbuild · 2019-06-03T19:47:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-06-04T08:32:22Z

+1

I could not find the failing test

fabiocos · 2019-06-04T08:35:14Z

please test

cmsbuild · 2019-06-04T08:35:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/737/console Started: 2019/06/04 10:36

cmsbuild · 2019-06-04T13:32:40Z

+1
Tested at: 0f65aee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17128e/737/summary.html

cmsbuild · 2019-06-04T13:32:48Z

Comparison job queued.

cmsbuild · 2019-06-04T15:48:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17128e/737/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3210222
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3209887
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

Clang-Format

0f65aee

cmsbuild added this to the CMSSW_11_0_X milestone Jun 3, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 3, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 3, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 3, 2019

cmsbuild added tests-rejected and removed tests-started labels Jun 3, 2019

slava77 reviewed Jun 3, 2019

View reviewed changes

cmsbuild added comparison-available and removed comparison-pending labels Jun 3, 2019

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jun 3, 2019

cmsbuild added orp-approved and removed orp-pending labels Jun 4, 2019

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Jun 4, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 4, 2019

cmsbuild added tests-approved and removed tests-started labels Jun 4, 2019

cmsbuild merged commit dc09919 into master Jun 4, 2019

fabiocos mentioned this pull request Jun 4, 2019

Code format fixes after CMSSW_11_0_X_2019-06-04-1100 #27091

Merged

cmsbuild added comparison-available and removed comparison-pending labels Jun 4, 2019

fabiocos added a commit to fabiocos/cmssw that referenced this pull request Jun 4, 2019

Code format fixes after cms-sw#27069 and other integrated packages

c4cf929

cmsbuild mentioned this pull request Jun 4, 2019

Adapting MVAVariableHelper to new E/gamma UL format and removal of MultiToken #26814

Merged

smuzaffar deleted the code-format-reconstruction-099a21 branch June 7, 2019 06:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Running code-format for reconstruction #27069

Running code-format for reconstruction #27069

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019 •

edited

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

slava77 left a comment

slava77 Jun 3, 2019

slava77 Jun 3, 2019

slava77 Jun 3, 2019

cmsbuild commented Jun 3, 2019

slava77 commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

fabiocos commented Jun 4, 2019

fabiocos commented Jun 4, 2019

cmsbuild commented Jun 4, 2019 •

edited

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

Running code-format for reconstruction #27069

Running code-format for reconstruction #27069

Conversation

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019 • edited

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

slava77 left a comment

Choose a reason for hiding this comment

slava77 Jun 3, 2019

Choose a reason for hiding this comment

slava77 Jun 3, 2019

Choose a reason for hiding this comment

slava77 Jun 3, 2019

Choose a reason for hiding this comment

cmsbuild commented Jun 3, 2019

slava77 commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

fabiocos commented Jun 4, 2019

fabiocos commented Jun 4, 2019

cmsbuild commented Jun 4, 2019 • edited

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 3, 2019 •

edited

cmsbuild commented Jun 4, 2019 •

edited