Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herwig7 hadron flavour identification - backport to 94X #27096

Merged
merged 2 commits into from Jul 10, 2019

Conversation

knash
Copy link
Contributor

@knash knash commented Jun 4, 2019

PR description:

A backport of #26885 of hadron flavour identification with Herwig7) to 94X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2019

A new Pull Request was created by @knash for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/JetMCAlgos

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@santocch
Copy link

santocch commented Jun 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/845/console Started: 2019/06/08 10:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3faf1/845/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 106
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721225
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@santocch for my understanding, is this impacting in any way some persistent datatier?

@santocch
Copy link

@fabiocos this PR adds the "Herwig7" label to the list of labels checked for the "Auto" options: previously herwig++ was identified by "thePEG" label which could change in the future (thePEG is a common set of routine used by more than one generator). So I don't expect any impact on any datatier defined so far... and in the future "Herwig7" is a correct way to refer to the Herwig generator.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3581f33 into cms-sw:CMSSW_9_4_X Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants