Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport for OuterTrackingMonitorTrackingParticle #27101

Merged
merged 1 commit into from Jun 13, 2019

Conversation

emacdonald16
Copy link
Contributor

PR description:

Heavily modified nLayers variable; runs much faster now (~2.5 s/evt at 200PU, compared to ~400)

PR validation:

Compared output file before and after changes, and they were identical. Only difference is in run time.

if this PR is a backport please specify the original PR:

Original PR: #27090

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

A new Pull Request was created by @emacdonald16 for CMSSW_10_6_X.

It involves the following packages:

Validation/SiOuterTrackerV

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 5, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/759/console Started: 2019/06/05 10:48

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57a3f9/759/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211772
  • DQMHistoTests: Total failures: 34
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211404
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 5, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

@emacdonald16 is this backport needed because of the UL processing validation?

@emacdonald16
Copy link
Contributor Author

@fabiocos What is the UL processing validation? I thought a backport would be necessary since it was first reported in #26915 that the producer ran very slow at high PU. @jfernan2 also voted for the backport in the original PR, #27090.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c3662eb into cms-sw:CMSSW_10_6_X Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants