New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running code-format for db-reconstruction #27109
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27109/10219
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @cmsbuild for master. It involves the following packages: CondFormats/SiPixelTransient @ggovi, @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggovi apart for a few points that can be manually adjusted separately, the PR looks ok to me, and I will move forward with it. Please check it anyway
float cotbetaY[60]; | ||
float cotbetaX[5]; | ||
float cotalphaX[29]; | ||
SiPixelGenErrorEntry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
float* cotalphaX; | ||
boost::multi_array<SiPixelGenErrorEntry, 1> enty; //!< use 1d entry to store [60] barrel entries or [28] fpix entries | ||
boost::multi_array<SiPixelGenErrorEntry, 2> | ||
entx; //!< use 2d entry to store [5][29] barrel entries or [3][29] fpix entries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
#ifndef SI_PIXEL_TEMPLATE_STANDALONE | ||
static bool pushfile(const SiPixelGenErrorDBObject& dbobject, std::vector< SiPixelGenErrorStore > & pixelTemp); // load the private store with info from db | ||
static bool pushfile(const SiPixelGenErrorDBObject& dbobject, | ||
std::vector<SiPixelGenErrorStore>& pixelTemp); // load the private store with info from db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
float cotbetaX[5]; | ||
float cotalphaX[29]; | ||
SiPixelTemplateEntry | ||
enty[60]; //!< 60 Barrel y templates spanning cluster lengths from 0px to +18px [28 entries for fpix] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
std::vector<SiPixelTemplateStore>& pixelTemp, | ||
std::string dir = | ||
"CalibTracker/SiPixelESProducers/data/"); // *&^%$#@! Different default dir -- remove once FastSim is updated. | ||
static bool pushfile(const SiPixelTemplateDBObject& dbobject, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
+1 |
merge |
Applying code-format for CMSSW category db,reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/370//console
cms-bot has successfully run the following: