Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for db-reconstruction #27109

Merged
merged 1 commit into from Jun 6, 2019

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Jun 5, 2019

Applying code-format for CMSSW category db,reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/370//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27109/10219

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/772/console Started: 2019/06/05 13:02

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

CondFormats/SiPixelTransient

@ggovi, @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmusich, @seemasharmafnal, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb94e8/772/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3210222
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3209886
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jun 6, 2019

+1

  • technical
  • jenkins tests pass

Copy link
Contributor

@fabiocos fabiocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggovi apart for a few points that can be manually adjusted separately, the PR looks ok to me, and I will move forward with it. Please check it anyway

float cotbetaY[60];
float cotbetaX[5];
float cotalphaX[29];
SiPixelGenErrorEntry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fixed

float* cotalphaX;
boost::multi_array<SiPixelGenErrorEntry, 1> enty; //!< use 1d entry to store [60] barrel entries or [28] fpix entries
boost::multi_array<SiPixelGenErrorEntry, 2>
entx; //!< use 2d entry to store [5][29] barrel entries or [3][29] fpix entries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fixed

#ifndef SI_PIXEL_TEMPLATE_STANDALONE
static bool pushfile(const SiPixelGenErrorDBObject& dbobject, std::vector< SiPixelGenErrorStore > & pixelTemp); // load the private store with info from db
static bool pushfile(const SiPixelGenErrorDBObject& dbobject,
std::vector<SiPixelGenErrorStore>& pixelTemp); // load the private store with info from db
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fixed

float cotbetaX[5];
float cotalphaX[29];
SiPixelTemplateEntry
enty[60]; //!< 60 Barrel y templates spanning cluster lengths from 0px to +18px [28 entries for fpix]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fixed

std::vector<SiPixelTemplateStore>& pixelTemp,
std::string dir =
"CalibTracker/SiPixelESProducers/data/"); // *&^%$#@! Different default dir -- remove once FastSim is updated.
static bool pushfile(const SiPixelTemplateDBObject& dbobject,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fixed

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

merge

@cmsbuild cmsbuild merged commit c589de1 into master Jun 6, 2019
@smuzaffar smuzaffar deleted the code-format-db-reconstruction-bdb1ee branch June 7, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants