New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tau validation for phase 2 #27120
Changes from 4 commits
ccb41fe
014e678
f2e79c7
6c54299
751242d
af33e54
29a76e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,7 +129,7 @@ void TauTagValidation::bookHistograms(DQMStore::IBooker& ibooker, | |
ibooker.setCurrentFolder("RecoTauV/" + TauProducer_ + extensionName_ + "_Summary"); | ||
hinfo summaryHinfo = (histoSettings_.exists("summary")) | ||
? hinfo(histoSettings_.getParameter<edm::ParameterSet>("summary")) | ||
: hinfo(21, -0.5, 20.5); | ||
: hinfo(discriminators_.size(), -0.5, discriminators_.size() - 0.5); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @steggema is this change creating a non null number of bins histogram in all cases? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For all regular cases yes, but it may be a good idea to add a check here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please do so, we are having issues while merging such histograms: #26727 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was addressed by af33e54. |
||
summaryTemp = | ||
ibooker.book1D("summaryPlotNum", "summaryPlotNum", summaryHinfo.nbins, summaryHinfo.min, summaryHinfo.max); | ||
summaryMap.insert(std::make_pair(refCollection_ + "Num", summaryTemp)); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steggema I don't understand why this clone is needed since no modifications are done afterwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point is that a MiniAOD era modifier changes process.tauGenJets, so it needs to have a different name and can't be the same object (i.e. if you write tauGenJetsForVal = tauGenJets it will just be a pointer). Maybe there's a better solution (... import as ... didn't work either).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see thanks