Improvements to PSet Entry implementation

[Dr15Jones]

PR description:

This is a refactoring of the code to improve maintenance as well as to move construction of data structures from dynamic load time to compile time.

PR validation:

All framework unit tests pass.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27127/10256

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/802/console Started: 2019/06/06 17:25

[cmsbuild]

+1
Tested at: e99a661
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0581c6/802/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Running code-format for daq-l1-reconstruction #27110 @cms-sw: Running code-format for daq-l1-reconstruction
• Running code-format for analysis-reconstruction #27114 @cms-sw: Running code-format for analysis-reconstruction
• DD4hep: Augment tested features and enable runing the tests without disabling biglibs #26998 @ianna: DD4hep: Augment tested features and enable runing the tests without disabling biglibs
• Running code-format for reconstruction #27080 @cms-sw: Running code-format for reconstruction
• Running code-format for reconstruction #27078 @cms-sw: Running code-format for reconstruction
• Running code-format for reconstruction #27076 @cms-sw: Running code-format for reconstruction
• Running code-format for reconstruction #27075 @cms-sw: Running code-format for reconstruction
• Running code-format for reconstruction #27074 @cms-sw: Running code-format for reconstruction

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0581c6/802/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0581c6/802/git-merge-result

[cmsbuild]

Comparison job queued.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0581c6/802/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3215458
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215123
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

+1