Phase2-hcx209 Enable RecHits for HFNose

[bsunanda]

PR description:

Enable recruit collection for HFNose

PR validation:

Tested with workflows of Phase2

if this PR is a backport please specify the original PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27129/10261

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @felicepantaleo, @rovere, @argiro, @cseez, @pfs, @lgray, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/805/console Started: 2019/06/06 20:32

[cmsbuild]

The code-checks are being triggered in jenkins.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27129/10263

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27129/10263/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27129/10263/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27129/10264

• This PR adds an extra 24KB to repository

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27129/10385

• This PR adds an extra 24KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/963/console Started: 2019/06/14 22:01

[cmsbuild]

Pull request #27129 was updated. @perrotta, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: a9a978f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-187199/963/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-187199/963/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3254096
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3253760
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

HFNose is only enbled in geometry D31, as far as I can see.
Is there a workflow with such a geometry that we can use for the tests?

[bsunanda]

There is a workflow 26234.0 which uses D31 geometry. In fact I tested this and also #27213 using that workflow. It can be activated only with -w upgrade

[perrotta]

+1

• RecHits enabled and made available in reco output: 90 kB/evt content added in the suggested wf 26234.0
• Jenkins tests pass and show no differences in workflows which do not include D31 geometry, as expected

[bsunanda]

@kpedro88 Could you please approve this?

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1