Backport of SiPixel quality harvester for Ultra legacy

[tocheng]

PR description:

The PR is to update pixel quality harvester for Run-2 ultra legacy

PR validation:

The PR update the bad ROC tagging by

• using per-layer for Bpix / per-ring for Fpix average digi occupancy instead of average occupancy over the full detector
• using layer/ring dependent fraction threshold to apply the optimized pixel quality tagging
• further reduce redundant payloads

Pixel quality tagging are optimized with layer/ring dependent thresholds with pixel offline group.

No effect on CMSSW standard workflows.

if this PR is a backport please specify the original PR:

This is backport of PR #27050

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

A new Pull Request was created by @tocheng (Tongguang) for CMSSW_10_6_X.

It involves the following packages:

CalibTracker/SiPixelQuality

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from SiPixel quality harvester for Ultra legacy #27050

[tocheng]

backport #27050

[tocheng]

@cmsbuild please test workflow 1001.2, 1040

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/807/console Started: 2019/06/06 22:13

[cmsbuild]

+1
Tested at: 33e00df
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97cb3/807/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97cb3/807/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-f97cb3/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-f97cb3/1040.0_RunZeroBias2017F+RunZeroBias2017F+TIER0RAWSIPIXELCAL+ALCASPLITSIPIXELCAL+ALCAHARVDSIPIXELCAL

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3206400
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3206064
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[tocheng]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1