Use ESGetToken in BufferedBoostIOESProducer

[makortel]

PR description:

Title says it all (part of #26748)

PR validation:

Code compiles.

[makortel]

@cmsbuild, please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27132/10269

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/810/console Started: 2019/06/07 00:07

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CondTools/Hcal

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: c7d419f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc1320/810/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc1320/810/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3215458
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215123
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[makortel]

Let me use the occasion to ask why there are plugins defined in CondTools/Hcal/bin

cmssw/CondTools/Hcal/bin/BuildFile.xml

Lines 16 to 20 in 17507fb

	<flags EDM_PLUGIN="1"/>
	<library file="scaleGains.cc" name="CondToolsHcalScaleGains"> </library>
	<library file="corrGains.cc" name="CondToolsHcalCorrGains"> </library>
	<library file="corrResps.cc" name="CondToolsHcalCorrResps"> </library>
	<library file="modGains.cc" name="CondToolsHcalModGains"> </library>

Could they be moved under plugins? @bsunanda

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@makortel I agree this does not sound the desired structure

[fabiocos]

+1