New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running code-format for geometry #27133
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27133/10271
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @cmsbuild for master. It involves the following packages: Geometry/CaloTopology @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
firstHERing_ = lastHBRing_; //crossover | ||
lastHERing_ = firstHERing_ + std::max(nEtaHE_ - 1, 0); //max = protection for case with no HE | ||
firstHFRing_ = | ||
lastHERing_ + 1; //no crossover for CaloTowers; HF crossover cells go in the subsequent non-crossover HF tower |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
if (ieta == 1) { //no ieta=0 | ||
ieta = -1; | ||
} else if (ieta == | ||
firstHEDoublePhiRing_) { //currently double phi, going to single phi (positive eta) -> extra neighbor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
else iphi-=2; | ||
dd.emplace_back(CaloTowerDetId(ieta, ((iphi + 1) % 72) + 1)); | ||
} else if (ieta - 1 == | ||
-firstHFQuadPhiRing_) { //currently double phi, going to quad phi (negative eta) -> change numbering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
if (ieta == -1) { //no ieta=0 | ||
ieta = 1; | ||
} else if (ieta == | ||
-firstHEDoublePhiRing_) { //currently double phi, going to single phi (negative eta) -> extra neighbor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
if ((iphi%2)==0) iphi--; | ||
dd.emplace_back(CaloTowerDetId(ieta, iphi + 1)); | ||
} else if (ieta + 1 == | ||
firstHEDoublePhiRing_) { //currently single phi, going to double phi (positive eta) -> change numbering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
else iphi-=2; | ||
dd.emplace_back(CaloTowerDetId(ieta, ((iphi + 1) % 72) + 1)); | ||
} else if (ieta + 1 == | ||
firstHFQuadPhiRing_) { //currently double phi, going to quad phi (positive eta) -> change numbering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
+1 |
Applying code-format for CMSSW category geometry.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/375//console
cms-bot has successfully run the following: