Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for alca-db #27138

Merged
merged 1 commit into from Jun 10, 2019
Merged

Running code-format for alca-db #27138

merged 1 commit into from Jun 10, 2019

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Jun 7, 2019

Applying code-format for CMSSW category alca,db.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/373//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 7, 2019

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 7, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 7, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27138/10275

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/816/console Started: 2019/06/07 08:58

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 7, 2019

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

CondFormats/SiStripObjects

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@erikbutz, @tocheng, @VinInn, @mmusich, @threus, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 7, 2019

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bddaa/816/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3215458
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215123
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

@ggovi @christopheralanwest @tocheng this PR looks ok to me, I will move forward with its integration, please have a look at it anyway

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 07cbc89 into master Jun 10, 2019
@smuzaffar smuzaffar deleted the code-format-alca-db-233572 branch June 11, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants