Running code-format for reconstruction #27140
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27140/10277
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @cmsbuild for master. It involves the following packages: DataFormats/SiStripCluster @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| // if hit is good check to make sure that we are keeping pixel hits | ||
| if (excludePixelHits_) { | ||
| if ((detid.det() == DetId::Tracker) && | ||
| ((detid.subdetId() == 1) || (detid.subdetId() == 2))) { // check for pixel hits |
| auto score2 = score[t2]; | ||
|
|
||
| constexpr float almostSame = | ||
| 0.01f; // difference rather than ratio due to possible negative values for score |
| float rPVerr = sqrt( | ||
| bestVertexError.x() * | ||
| bestVertexError | ||
| .y()); // shouldn't it be bestVertex.xError()*bestVertex.xError()+bestVertex.yError()*bestVertex.yError() ?!?!? |
There was a problem hiding this comment.
bad comment line break issue
| if (maxDz[2] < std::numeric_limits<float>::max() || maxDr[2] < std::numeric_limits<float>::max()) { | ||
| // if not primaryVertices are reconstructed, check compatibility w.r.t. beam spot | ||
| Point bestVertex = | ||
| getBestVertex(trk, vertices, minNVtxTrk); // min number of tracks [2 (=default) for offline, 3 for HLT] |
| if (dzWPVerr_par[2] < std::numeric_limits<float>::max() || drWPVerr_par[2] < std::numeric_limits<float>::max()) { | ||
| Point bestVertexError(-1., -1., -1.); | ||
| Point bestVertex = getBestVertex_withError( | ||
| trk, vertices, bestVertexError, minNVtxTrk); // min number of tracks [2 (=default) for offline, 3 for HLT] |
| // in case of split-hit do full conbinatorics | ||
| auto li = ih; | ||
| while ((++li) != nh1 && id1 == rh1[k1][li].first) | ||
| ; |
There was a problem hiding this comment.
should we put empty loop {} block instead?
| inputs["trk_dz"] = trk.dz(beamSpot.position()); // Training done without taking absolute value | ||
| inputs["trk_dxyClosestPV"] = trk.dxy(bestVertex); // Training done without taking absolute value | ||
| inputs["trk_dzClosestPVNorm"] = | ||
| std::max(-0.2, std::min(trk.dz(bestVertex), 0.2)); // Training done without taking absolute value |
|
|
||
| if (GeomDetEnumerators::isTrackerStrip(theGeometry->geomDetSubDetector(id.subdetId()))) { | ||
| if (subdetStoN_[subdet_cnt - | ||
| 1]) { //check that hit is in a det belonging to a subdet where we decided to apply a S/N cut |
|
+1
#27140 (review) |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Applying code-format for CMSSW category reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/377//console
cms-bot has successfully run the following: