New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-sim33 Add testing tool for Geant4/GeantV compatibility #27156
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27156/10301
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: SimG4CMS/Calo @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda fine for me to integrate this tool, still it looks like a Validation package, just based on bare ROOT instead of ME... |
@fabiocos This is specially used for comparing Geant4 and GeantV results. So it is not a standard validation tool and that is why didn't use MonitorElement. Kindly integrate this |
+1 |
PR description:
Analyzer to analyze hits produced by a special hit producer in Geant4 and GeantV applications
PR validation:
Tested with privately produced files with GeantV application
if this PR is a backport please specify the original PR:
tested with 2018 geometry configuration and no back porting is required