Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TICL Reorganization, reloaded. #27160

Merged
merged 17 commits into from Jun 26, 2019

Commits on Jun 25, 2019

  1. Copy the full SHA
    b137966 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ba6d14f View commit details
    Browse the repository at this point in the history
  3. Add fractions in Tracksters

    rovere committed Jun 25, 2019
    Copy the full SHA
    69e6753 View commit details
    Browse the repository at this point in the history
  4. Code-format

    rovere committed Jun 25, 2019
    Copy the full SHA
    08e63c5 View commit details
    Browse the repository at this point in the history
  5. TICL Reorganization

    Several changes entered this commit.
    
    * The data structures used by TICL have been moved into
      DataFormats/TICL, that has to be added as a CMSSW package.
      Tracksters and Tile are currently present. The encapsulation of
      std::array as a transient data member of a Tile is due to the fact
      that ROOT natively supports those and refuses to create ad-hoc
      dictionaries. Moreover, at present, an std::array cannot sit at the
      top of a ROOT branch requiring, once again, its encapsulation.
    * The "master Tile" has been added as a single producer. A unique Tile
      containing all the 2D reconstructed clusters is created once and put
      into the Event. All iterations will fetch it from the event and mask
      the 2D clusters on the fly. This required also some changes to the
      clusters filters logic. Now the filters produce also a vector<float>
      that represents the result of merging their input mask with their
      own selection. TICL iterations will make use of the filter's
      vector<float> to dynamically mask clusters from the "master Tile".
    * The fractions have been added to the Tracksters. The sharing of the
      energy of 2D clusters is flat and based on their multiplicity, i.e,
      a fraction of energy/multiplicity is assigned to all Tracksters that
      use the 2D clusters. Better splitting algorithms can be studies or
      Machine Learning techniques could be put at work here.
    * The hits and fraction of the Trackster are now correctly populated.
      This required an additional loop over the components of each 2D
      cluster. In the future the CaloCluster, PFCluster and hits and
      fractions data structures could be reviewed or, at least, TICL could
      use some other, more efficient, internal data representation and
      collapse into the legacy ones only at the very last stage.
    rovere committed Jun 25, 2019
    Copy the full SHA
    b06f76c View commit details
    Browse the repository at this point in the history
  6. Final round of code-format

    rovere committed Jun 25, 2019
    Copy the full SHA
    9fb2752 View commit details
    Browse the repository at this point in the history
  7. Add comments in the code

    rovere committed Jun 25, 2019
    Copy the full SHA
    65a33af View commit details
    Browse the repository at this point in the history
  8. Appy code-checks

    rovere committed Jun 25, 2019
    Copy the full SHA
    7cb4a0c View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    9b2e213 View commit details
    Browse the repository at this point in the history
  10. Rename DataFormats directory

    rovere committed Jun 25, 2019
    Copy the full SHA
    b6ec09a View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    91da8d7 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    9744191 View commit details
    Browse the repository at this point in the history
  13. Rename accessor methods

    rovere committed Jun 25, 2019
    Copy the full SHA
    05f226d View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    75a24d7 View commit details
    Browse the repository at this point in the history
  15. Copy the full SHA
    cd2b731 View commit details
    Browse the repository at this point in the history
  16. Copy the full SHA
    a3c5a15 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Copy the full SHA
    fba76c7 View commit details
    Browse the repository at this point in the history