New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TICL Reorganization, reloaded. #27160
Merged
cmsbuild
merged 17 commits into
cms-sw:master
from
rovere:TICL_withTilesAndFractions_fix26996
Jun 26, 2019
Merged
TICL Reorganization, reloaded. #27160
cmsbuild
merged 17 commits into
cms-sw:master
from
rovere:TICL_withTilesAndFractions_fix26996
Jun 26, 2019
Commits on Jun 25, 2019
-
-
-
-
-
Several changes entered this commit. * The data structures used by TICL have been moved into DataFormats/TICL, that has to be added as a CMSSW package. Tracksters and Tile are currently present. The encapsulation of std::array as a transient data member of a Tile is due to the fact that ROOT natively supports those and refuses to create ad-hoc dictionaries. Moreover, at present, an std::array cannot sit at the top of a ROOT branch requiring, once again, its encapsulation. * The "master Tile" has been added as a single producer. A unique Tile containing all the 2D reconstructed clusters is created once and put into the Event. All iterations will fetch it from the event and mask the 2D clusters on the fly. This required also some changes to the clusters filters logic. Now the filters produce also a vector<float> that represents the result of merging their input mask with their own selection. TICL iterations will make use of the filter's vector<float> to dynamically mask clusters from the "master Tile". * The fractions have been added to the Tracksters. The sharing of the energy of 2D clusters is flat and based on their multiplicity, i.e, a fraction of energy/multiplicity is assigned to all Tracksters that use the 2D clusters. Better splitting algorithms can be studies or Machine Learning techniques could be put at work here. * The hits and fraction of the Trackster are now correctly populated. This required an additional loop over the components of each 2D cluster. In the future the CaloCluster, PFCluster and hits and fractions data structures could be reviewed or, at least, TICL could use some other, more efficient, internal data representation and collapse into the legacy ones only at the very last stage.
-
-
-
-
-
-
-
-
-
-
-
Commits on Jun 26, 2019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.