Running code-format for alca-db #27168
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27168/10318
|
|
ping |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @cmsbuild for master. It involves the following packages: CondFormats/SiPixelObjects @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
There was a problem hiding this comment.
@christopheralanwest @tocheng @ggovi apart for a few points to be adjusted afterwards, the PR looks ok to me. I will integrate it, please have a look at it anyway
|
|
||
| unsigned int numberOfRowsToAverageOver_; //THIS WILL BE HARDCODED TO 1 (no averaging) DON'T CHANGE UNLESS YOU KNOW WHAT YOU ARE DOING! | ||
| unsigned int | ||
| numberOfRowsToAverageOver_; //THIS WILL BE HARDCODED TO 1 (no averaging) DON'T CHANGE UNLESS YOU KNOW WHAT YOU ARE DOING! |
|
|
||
| float pedPrecision, gainPrecision; | ||
|
|
||
| unsigned int numberOfRowsToAverageOver_; //THIS WILL BE HARDCODED TO 80 (all rows in a ROC) DON'T CHANGE UNLESS YOU KNOW WHAT YOU ARE DOING! | ||
| unsigned int | ||
| numberOfRowsToAverageOver_; //THIS WILL BE HARDCODED TO 80 (all rows in a ROC) DON'T CHANGE UNLESS YOU KNOW WHAT YOU ARE DOING! |
|
|
||
| unsigned int numberOfRowsToAverageOver_; //THIS WILL BE HARDCODED TO 80 (all rows in a ROC) DON'T CHANGE UNLESS YOU KNOW WHAT YOU ARE DOING! | ||
| unsigned int | ||
| numberOfRowsToAverageOver_; //THIS WILL BE HARDCODED TO 80 (all rows in a ROC) DON'T CHANGE UNLESS YOU KNOW WHAT YOU ARE DOING! |
| std::vector<disabledModuleType>::const_iterator iter = std::lower_bound( | ||
| disabledModules.begin(), disabledModules.end(), detid, SiPixelQuality::BadComponentStrictWeakOrdering()); | ||
| if (iter != disabledModules.end() && iter->DetID == detid && | ||
| iter->errorType == 0) //errorType 0 corresponds to "whole" dead module |
|
+1 |
|
merge |
Applying code-format for CMSSW category alca,db.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/382//console
cms-bot has successfully run the following: