Running code-format for reconstruction #27170

cmsbuild · 2019-06-11T08:31:58Z

Applying code-format for CMSSW category reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/391//console

cms-bot has successfully run the following:

scram build code-checks-all
scram build code-format-all
scram build

cmsbuild · 2019-06-11T08:32:00Z

please test

cmsbuild · 2019-06-11T08:32:32Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-11T08:39:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27170/10320

This PR adds an extra 8KB to repository

slava77 · 2019-06-11T15:10:07Z

@cmsbuild please test
the earlier "please test" was not picked up for some reason

cmsbuild · 2019-06-11T15:10:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/877/console Started: 2019/06/11 17:11

cmsbuild · 2019-06-11T15:10:45Z

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/CaloRecHit
DataFormats/HcalRecHit
DataFormats/Math
DataFormats/SiPixelCluster
EventFilter/SiPixelRawToDigi
RecoLocalTracker/SiPixelClusterizer
RecoLocalTracker/SiPixelRecHits
RecoPixelVertexing/PixelTrackFitting
RecoPixelVertexing/PixelVertexFinding

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dkotlins, @ebrondol, @gpetruc, @mariadalfonso, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-06-11T19:33:43Z

+1
Tested at: 146bc98
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0aec1/877/summary.html

cmsbuild · 2019-06-11T19:33:46Z

Comparison job queued.

cmsbuild · 2019-06-11T21:43:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0aec1/877/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3215458
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215122
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2019-06-11T23:24:02Z

DataFormats/Math/interface/GeantUnits.h

    {
      return (mm3 / 1.e9);
    }

    template <class NumType>
-    inline constexpr NumType convertUnitsTo(long double desiredUnits, NumType val) // Convert Geant units to desired units
+    inline constexpr NumType convertUnitsTo(long double desiredUnits,
+                                            NumType val)  // Convert Geant units to desired units


comment line break issue

slava77 · 2019-06-11T23:34:00Z

EventFilter/SiPixelRawToDigi/test/SiPixelRawDumper.cc

-    for(int j=0;j<36;++j) {decodeErrors[i][j]=0; decodeErrors000[i][j]=0; decodeErrorsDouble[i][j]=0;}
+  printLocal = theConfig.getUntrackedParameter<int>("Verbosity", 1);
+  printThreshold =
+      theConfig.getUntrackedParameter<double>("PrintThreshold", 0.001);  // threshold per event for printing errors


comment line break issue

slava77 · 2019-06-11T23:48:52Z

RecoPixelVertexing/PixelTrackFitting/interface/PixelTrackBuilder.h

+                     const MagneticField* mf,
+                     const GlobalPoint& reference = GlobalPoint(0,
+                                                                0,
+                                                                0)  // reference point of a track for IP computation


comment line break issue

slava77 · 2019-06-11T23:50:25Z

RecoPixelVertexing/PixelTrackFitting/src/KFBasedPixelFitter.cc

+    : TValidTrackingRecHit(*geom) {
+  localPosition_ = LocalPoint(0., 0., 0.);
+  localError_ =
+      LocalError(sqr(beamSpot.BeamWidthX()), 0.0, sqr(beamSpot.sigmaZ()));  //neglect XY differences and BS slope


comment line break issue

slava77 · 2019-06-11T23:53:38Z

RecoPixelVertexing/PixelVertexFinding/src/FastPrimaryVertexWithWeightsProducer.cc

+  const double
+      m_minSizeY_q;  // Use only pixel clusters with sizeY > PixelCellHeightOverWidth * |jetZOverRho| + minSizeY_q
+  const double
+      m_maxSizeY_q;  // Use only pixel clusters with sizeY < PixelCellHeightOverWidth * |jetZOverRho| + maxSizeY_q


comment line break issues

slava77 · 2019-06-11T23:53:50Z

RecoPixelVertexing/PixelVertexFinding/src/FastPrimaryVertexWithWeightsProducer.cc

+  const double m_weight_rho_up;       // used in weight_rho = (m_weight_rho_up - ClusterRho)/m_weight_rho_up
+  const double m_weight_charge_peak;  // Give the maximum weight_charge for a cluster with Charge = m_weight_charge_peak
+  const double
+      m_peakSizeY_q;  // Give the maximum weight_sizeY for a cluster with sizeY = PixelCellHeightOverWidth * |jetZOverRho| + peakSizeY_q


comment line break issue

slava77 · 2019-06-11T23:54:36Z

RecoPixelVertexing/PixelVertexFinding/src/FastPrimaryVertexWithWeightsProducer.cc

+                 std::abs(deltaPhi((*jit)->momentum().Phi(), v_bs.phi())) <= m_maxDeltaPhi_EC)  //EC
+            ) {
+              float z = v.z() - ((v.x() - beamSpot->x0()) * px + (v.y() - beamSpot->y0()) * py) / pt * pz /
+                                    pt;  //calculate z-projection


likely comment line break issue

slava77 · 2019-06-11T23:55:06Z

RecoPixelVertexing/PixelVertexFinding/src/FastPrimaryVertexWithWeightsProducer.cc

+  *zClusterQuality = -1;
+  if (nWeightedTot != 0) {
+    *zClusterQuality =
+        nWeightedTotPeak / sqrt(nWeightedTot / (2 * half_width_peak));  // where 30 is the beam spot lenght


comment line break issue

slava77 · 2019-06-11T23:56:21Z

RecoPixelVertexing/PixelVertexFinding/src/PixelVertexProducer.cc

+    : verbose_(conf.getParameter<int>("Verbosity"))  // 0 silent, 1 chatty, 2 loud
+      ,
+      ptMin_(conf.getParameter<double>("PtMin"))  // 1.0 GeV
+      ,


these are apparently comment line related issues

slava77 · 2019-06-11T23:56:37Z

RecoPixelVertexing/PixelVertexFinding/src/PixelVertexProducer.cc

+  math::XYZPoint myPoint(0., 0., 0.);
+  if (bsHandle.isValid())
+    myPoint =
+        math::XYZPoint(bsHandle->x0(), bsHandle->y0(), 0.);  //FIXME: fix last coordinate with vertex.z() at same time


comment line break issue

slava77 · 2019-06-11T23:58:57Z

+1

for #27170 146bc98

technical
jenkins tests pass

issues reported in #27170 (review)
are relatively minor and can be addressed in a follow-up PR

cmsbuild · 2019-06-11T23:59:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-06-12T08:22:19Z

+1

cmsbuild added 2 commits June 11, 2019 10:29

Clang-tidy

5839b62

Clang-Format

146bc98

cmsbuild added this to the CMSSW_11_0_X milestone Jun 11, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 11, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 11, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 11, 2019

cmsbuild added tests-approved and removed tests-started labels Jun 11, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 11, 2019

slava77 reviewed Jun 11, 2019

View reviewed changes

cmsbuild removed pending-signatures reconstruction-pending labels Jun 11, 2019

cmsbuild added fully-signed reconstruction-approved labels Jun 11, 2019

cmsbuild added orp-approved and removed orp-pending labels Jun 12, 2019

cmsbuild merged commit c345719 into master Jun 12, 2019

cmsbuild mentioned this pull request Jun 12, 2019

Fix python3 interface problem in RecoTauTag/RecoTau #27189

Merged

smuzaffar deleted the code-format-reconstruction-60a708 branch June 20, 2019 20:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Running code-format for reconstruction #27170

Running code-format for reconstruction #27170

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

slava77 commented Jun 11, 2019

cmsbuild commented Jun 11, 2019 •

edited

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

slava77 Jun 11, 2019

slava77 Jun 11, 2019

slava77 Jun 11, 2019

slava77 Jun 11, 2019

slava77 Jun 11, 2019

slava77 Jun 11, 2019

slava77 Jun 11, 2019

slava77 Jun 11, 2019

slava77 Jun 11, 2019

slava77 Jun 11, 2019

slava77 commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

fabiocos commented Jun 12, 2019

Running code-format for reconstruction #27170

Running code-format for reconstruction #27170

Conversation

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

slava77 commented Jun 11, 2019

cmsbuild commented Jun 11, 2019 • edited

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slava77 commented Jun 11, 2019

cmsbuild commented Jun 11, 2019

fabiocos commented Jun 12, 2019

cmsbuild commented Jun 11, 2019 •

edited