Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust clang-format after CMSSW_11_0_X_2019-06-13-1100 #27199

Merged
merged 1 commit into from Jun 16, 2019

Conversation

fabiocos
Copy link
Contributor

PR description:

Address comments during the review of clang-format review up to CMSSW_11_0_X_2019-06-13-1100

PR validation:

code compiles

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fabiocos
Copy link
Contributor Author

fabiocos commented Jun 13, 2019

@perrotta concerning your comments to #27113 they are not addressed here because I think they concern more the definition of the formatting itself, than some possible simple adjustment of the code to cope with its current definition

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27199/10371

  • This PR adds an extra 112KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

DQM/TrackingMonitor
DataFormats/Math
DataFormats/MuonDetId
EventFilter/SiPixelRawToDigi
FastSimulation/Tracking
Geometry/CaloTopology
PhysicsTools/PatAlgos
RecoPixelVertexing/PixelTrackFitting
RecoPixelVertexing/PixelVertexFinding
RecoTracker/FinalTrackSelectors
SimTracker/SiPhase2Digitizer

@perrotta, @ssekmen, @Dr15Jones, @lveldere, @kmaeshima, @cvuosalo, @civanch, @schneiml, @andrius-k, @mdhildreth, @ianna, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @santocch, @kpedro88 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @felicepantaleo, @jandrea, @rappoccio, @HeinerTholen, @fioriNTU, @ahinzmann, @threus, @peruzzim, @seemasharmafnal, @mmarionncern, @hdelanno, @JyothsnaKomaragiri, @makortel, @smoortga, @acaudron, @jhgoh, @jdolen, @HuguesBrun, @drkovalskyi, @ferencek, @trocino, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @ptcox, @nhanvtran, @gkasieczka, @schoef, @mschrode, @idebruyn, @ebrondol, @mtosi, @dgulhan, @clelange, @Martin-Grunewald, @battibass, @calderona, @mverzett, @dkotlins, @gpetruc, @matt-komm, @mariadalfonso, @pvmulder, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/951/console Started: 2019/06/14 00:00

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e99eb/951/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254096
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3253761
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@ssekmen
Copy link
Contributor

ssekmen commented Jun 14, 2019

+1

@jfernan2
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

+upgrade

@santocch
Copy link

+1

@fabiocos
Copy link
Contributor Author

@civanch @cvuosalo the PR is purely technical, I move forward with its integration, please have a look and comment for further updates in case

@fabiocos
Copy link
Contributor Author

+1

@fabiocos
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit dae3e97 into cms-sw:master Jun 16, 2019
@cvuosalo
Copy link
Contributor

+1

@fabiocos fabiocos deleted the fc-fixFormat20190613 branch June 18, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment