zeroing PF clustering uncertainty : 106X

[Sam-Harper]

PR description:

This PR zeros out the PF cluster uncertainty by default as discussed in the PPD general meeting last week. This because those values are not used anywhere, do not really make sense and will for the 2017UL be inaccurate in the endcap.

This is a super minor thing and should not hold anything. If it gets in it gets in, if it doesnt , it doesnt.

if this PR is a backport please specify the original PR:

backport of #27182

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_10_6_X.

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @felicepantaleo, @cbernet, @rovere, @lgray, @bachtis, @hatakeyamak, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from zeroing PF clustering uncertainty #27182

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/952/console Started: 2019/06/14 11:43

[perrotta]

backport of #27182

[cmsbuild]

+1
Tested at: 91ba701
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0823f8/952/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0823f8/952/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 88 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3208236
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3207901
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• Identical backport (a part for spaces...) of zeroing PF clustering uncertainty #27182
• Outputs show all correctedEnergyUncertanty'es zeroed, for all EGamma related clusters, as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[Sam-Harper]

+1

• Identical backport (a part for spaces...) of zeroing PF clustering uncertainty #27182

Yes I was going to fix it but then decided not to as there was not reason to (it happened on a surprisingly messy rebase due to code formating).

[fabiocos]

@Sam-Harper @perrotta @franzoni @srimanob I understand that this backport is not crucial for 10_6_1, but it would be "nice to have". It did not enter 11_0_0_pre2, but as the validation of 10_6_1 will move in parallel I think it makes sense to integrate it (it looks quite simple in any case)

[Sam-Harper]

indeed, it is merely guarding against a hypothetical user in 3 years time accidentally using the ECAL PF cluster uncertainty which is set to a slightly too low value in the endcap, specifically high endcap. Currently there is no such use case for this variable CMSSW.

So it is nice to have but not at all necessary to have if it causes problems.

Thanks for doing this.

[fabiocos]

+1