Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid playback segfault on empty file list53x #2721

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 4, 2014

When running the mixing module in playback mode, if the secondary input source is given an empty file list, a segfault resulted when attempting to throw an exception. This pull request fixes the segfault so that the exception is thrown.
This pull request also improves exception messages that occur on an empty file list for the secondary source when playback mode is not used.
This code bug has been there for a long time. This segfault has been observed as far back as 5_3_X.
Pull request requested in 5_3_X by David Lange.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2014

A new Pull Request was created by @wmtan for CMSSW_5_3_X.

Avoid playback segfault on empty file list53x

It involves the following packages:

IOPool/Input

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@smuzaffar
Copy link
Contributor

+tested
@davidlange6, we should also include this in next 53X patch release

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). @smuzaffar can you please take care of it?

@davidlange6
Copy link
Contributor

+1

yes. Thanks
On Mar 5, 2014, at 2:35 PM, Malik Shahzad Muzaffar notifications@github.com
wrote:

+tested
@davidlange6, we should also include this in next 53X patch release


Reply to this email directly or view it on GitHub.

smuzaffar added a commit that referenced this pull request Mar 5, 2014
…ist53X

Avoid playback segfault on empty file list53x
@smuzaffar smuzaffar merged commit bede971 into cms-sw:CMSSW_5_3_X Mar 5, 2014
@wmtan wmtan deleted the AvoidPlaybackSegfaultOnEmptyFileList53X branch March 5, 2014 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants