New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running code-format for dqm #27232
Running code-format for dqm #27232
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27232/10417
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @cmsbuild for master. It involves the following packages: DQMServices/Core @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfernan2 I will fix the split statements in a separate PR
neighborsX = nbinsX/2 - 1; //set neighbors for no overlap | ||
if (xMin_ != 0 && | ||
xMax_ != | ||
0) { //give users option for automatic mininum and maximum selection by inputting 0 to any of the parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
} | ||
if (yMin_ != 0 && | ||
yMax_ != | ||
0) { //give users option for automatic mininum and maximum selection by inputting 0 to any of the parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
double average = sum / (XWidth * YWidth - 1); | ||
double sigma = getNeighborSigma(average, groupx, groupy, XBlocks, YBlocks, neighborsX, neighborsY, h); | ||
sigma -= (average - blocksum) * | ||
(average - blocksum); //get rid of block being tested just like we did with the average |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
|
||
if (xMin_ != 0 && | ||
xMax_ != | ||
0) { //give users option for automatic mininum and maximum selection by inputting 0 to any of the parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
OK, no problem |
+1 |
Applying code-format for CMSSW category dqm.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/400//console
cms-bot has successfully run the following: