Running code-format for reconstruction #27233
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27233/10418
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @cmsbuild for master. It involves the following packages: DataFormats/EgammaCandidates @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
| math::XYZPointF positionAtVtx; // the track PCA to the beam spot | ||
| math::XYZPointF positionAtCalo; // the track PCA to the supercluster position | ||
| math::XYZVectorF momentumAtVtx; // the track momentum at the PCA to the beam spot | ||
| math::XYZVectorF |
There was a problem hiding this comment.
Just to notice a few line splits because of a comment at the end of the line.
I am not personally particularly against them here, though
| float sumEcalClusterEt; //sum pt of ecal clusters, vetoing clusters part of photon | ||
| float sumHcalClusterEt; //sum pt of hcal clusters, vetoing clusters part of photon | ||
| PflowIsolationVariables() | ||
| : |
There was a problem hiding this comment.
Kind of funny adjustment here...
| const std::vector<math::XYZVectorF>& trackPout, | ||
| const float mva, | ||
| ConversionAlgorithm algo) | ||
| : |
| uint8_t nSharedHits, | ||
| const float mva, | ||
| ConversionAlgorithm algo) | ||
| : |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Applying code-format for CMSSW category reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/402//console
cms-bot has successfully run the following: