New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed output file format: DQM/BeamMonitor --> BeamPixel application #27244
Conversation
@dinardo, CMSSW_11_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27244/10442
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Hi @dinardo, could you please make sure that subsystem name appears in the title of the PR? |
OK, it's done. |
Thanks Mauro, can you please add your name to the corresponding e-group on: https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts |
Hi, ok, but I'm not sure which e-group I belong to. I'm the developper and mantainer of the Online DQM aplication: BeamPixel which monitors the online beam spot exploiting only the pixel tracker information. |
I believe Online DQM under https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#Tracker_SiStrips_and_Pixels |
Hi, ok sure. When I try to change the page it says: DON'T UPDATE THIS PAGE - IT'S AUTO GENERATED Do you have the "power" :-) to add me to the list? |
The code-checks are being triggered in jenkins. |
OK, I've fixed the code checks. I guess we can proceed :-) |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27244/10476
|
A new Pull Request was created by @dinardo (Mauro) for master. It involves the following packages: DQM/BeamMonitor @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
OK, it's done. Thanks. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
I've changed the output file format in order to make it compliant with the other beam spot monitor application that monitor the beam spot
PR validation:
I've compiled the code. The change was very minimal.
if this PR is a backport please specify the original PR:
n.a.