Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed output file format: DQM/BeamMonitor --> BeamPixel application #27244

Merged
merged 2 commits into from Jun 20, 2019
Merged

Changed output file format: DQM/BeamMonitor --> BeamPixel application #27244

merged 2 commits into from Jun 20, 2019

Conversation

dinardo
Copy link
Contributor

@dinardo dinardo commented Jun 19, 2019

PR description:

I've changed the output file format in order to make it compliant with the other beam spot monitor application that monitor the beam spot

PR validation:

I've compiled the code. The change was very minimal.

if this PR is a backport please specify the original PR:

n.a.

@cmsbuild cmsbuild changed the base branch from CMSSW_11_0_X to master June 19, 2019 06:50
@cmsbuild
Copy link
Contributor

@dinardo, CMSSW_11_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27244/10442

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@jfernan2
Copy link
Contributor

Hi @dinardo, could you please make sure that subsystem name appears in the title of the PR?

@dinardo dinardo changed the title Changed output file format Changed output file format: DQM/BeamMonitor --> BeamPixel application Jun 19, 2019
@dinardo
Copy link
Contributor Author

dinardo commented Jun 19, 2019

OK, it's done.

@jfernan2
Copy link
Contributor

Thanks Mauro, can you please add your name to the corresponding e-group on: https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts

@dinardo
Copy link
Contributor Author

dinardo commented Jun 19, 2019

Hi, ok, but I'm not sure which e-group I belong to.

I'm the developper and mantainer of the Online DQM aplication: BeamPixel which monitors the online beam spot exploiting only the pixel tracker information.

@jfernan2
Copy link
Contributor

I believe Online DQM under https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#Tracker_SiStrips_and_Pixels
fits you since it covers Pixel.
BTW: the PR failed the code-checks, please fix before proceeding

@dinardo
Copy link
Contributor Author

dinardo commented Jun 19, 2019

Hi, ok sure.

When I try to change the page it says:

DON'T UPDATE THIS PAGE - IT'S AUTO GENERATED
IT WILL BE REFRESHED REGULARLY
%INCLUDE{https://ppdcontacts.web.cern.ch/PPDContacts/ppd_contacts}%

Do you have the "power" :-) to add me to the list?

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@dinardo
Copy link
Contributor Author

dinardo commented Jun 19, 2019

OK, I've fixed the code checks.

I guess we can proceed :-)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27244/10476

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinardo (Mauro) for master.

It involves the following packages:

DQM/BeamMonitor

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

@dinardo
Copy link
Contributor Author

dinardo commented Jun 19, 2019

OK, it's done.

Thanks.

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1063/console Started: 2019/06/19 17:57

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2177c7/1063/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254096
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3253761
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1844a22 into cms-sw:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants