Make statics constexpr in HcalTopology

[Dr15Jones]

PR description:

This fixes a problem when compiling using UBSAN as a static const object is still required to have storage assigned while a constexpr does not have storage.

PR validation:

This compiles and links using CMSSW_11_0_UBSAN_X_2019-06-18-1100 IB.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27249/10447

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Geometry/CaloTopology

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1022/console Started: 2019/06/19 10:25

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

[I pushed a commit to the wrong branch, sorry everyone]

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27249/10449

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #27249 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1023/console Started: 2019/06/19 11:01

[cmsbuild]

+1
Tested at: e317a5b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-706bff/1023/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-706bff/1023/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3254096
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3253760
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[bsunanda]

@Dr15Jones Chris I am making changes to HcalTopology and it has all the fixes suggested by you. I am making the PR for some dense indexing. Could this PR be closed as there will be conflicts. Please let me know

[fabiocos]

@bsunanda the simplest thing is that I merge this PR now and your rebase (if needed) on top of it

[fabiocos]

+1