Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Single-Iov Tracker Alignment Barycenter dump to Payload Inspector #27257

Merged
merged 3 commits into from Jun 26, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 19, 2019

PR description:

There might be cases in which instead of looking at the evolution of the Pixel barycenter over time one would just need to know the values for a single IOV.
This is addressed in this PR in which the (x,y,z) coordinate of the barycenters of all Tracker Sub-detectors are printed (corrected or uncorrected for the Tracker GPR - this is revelant in the case of MC in which the GPR is set to 0).

PR validation:

Testing locally with:

 getPayloadData.py --plugin pluginTrackerAlignment_PayloadInspector --plot plot_TrackerAlignmentBarycenters --tag TrackerAlignment_Upgrade2017_realistic_v3 --time_type Run --iovs '{"start_iov": "1", "end_iov": "1"}' --db Prod --test ;

returns the desired plot:

a5ede121-d103-45fb-80a5-bfec60b2987c

if this PR is a backport please specify the original PR:

This PR is not a backport

@mmusich
Copy link
Contributor Author

mmusich commented Jun 19, 2019

@sarafiorendi @francescobrivio FYI

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27257/10457

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/AlignmentPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mmusich mmusich force-pushed the addSingleIOVTkAlignmentBarycenterDump branch from abe59c8 to cc6fc78 Compare June 20, 2019 13:20
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27257/10499

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #27257 was updated. @ggovi, @cmsbuild can you please check and sign again.

@ggovi
Copy link
Contributor

ggovi commented Jun 25, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1144/console Started: 2019/06/25 10:18

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8f879/1144/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254598
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3254262
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Jun 25, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c6107a8 into cms-sw:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants