Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for visualization #27272

Merged
merged 1 commit into from Jun 20, 2019

Conversation

cmsbuild
Copy link
Contributor

Applying code-format for CMSSW category visualization.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/416//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27272/10474

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 19, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1046/console Started: 2019/06/19 15:21

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@alja updates are trivial, please have a look at them anyway

@cmsbuild cmsbuild merged commit 0a13398 into master Jun 20, 2019
@smuzaffar smuzaffar deleted the code-format-visualization-7fe24d branch June 20, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants