Sim G4 Geometry from dd4hep Tracked Flag #27295
Conversation
|
@fabiocos - FYI |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27295/10510
|
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@ianna thank you, I think this can be helpful in the transition period to avoid possible misconfigurations difficult to track |
|
+1 |
| @@ -29,6 +27,7 @@ class DDDWorld { | |||
| G4VPhysicalVolume *GetWorldVolumeForWorker() const { return m_world; } | |||
|
|
|||
| private: | |||
| void SetAsWorld(G4VPhysicalVolume *pv); | |||
There was a problem hiding this comment.
yes. It's DDDWorld self-initialisation - the method became private.
PR description:
PR validation:
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: