Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite and Improvements for PFRecHit and PFCluster Producers #2730

Merged
merged 61 commits into from Mar 14, 2014
Merged

Rewrite and Improvements for PFRecHit and PFCluster Producers #2730

merged 61 commits into from Mar 14, 2014

Commits on Mar 11, 2014

  1. Adding new hits

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    92a7f62 View commit details
    Browse the repository at this point in the history

  2. cleaning old code

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    e44523d View commit details
    Browse the repository at this point in the history

  3. Changed RecHit

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    df5ebb9 View commit details
    Browse the repository at this point in the history

  4. Removing stuff

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    9cf2615 View commit details
    Browse the repository at this point in the history

  5. fixing also the hash

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    75b8cd7 View commit details
    Browse the repository at this point in the history

  6. Added forgotten file

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    d25da46 View commit details
    Browse the repository at this point in the history

  7. Caching the 4 and 8 neighbours"

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    fc9de23 View commit details
    Browse the repository at this point in the history

  8. skeleton of PFClusterProducer Refactorization

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    b2230ac View commit details
    Browse the repository at this point in the history

  9. implement original PF topo cluster algorithm in new framework

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    999200a View commit details
    Browse the repository at this point in the history

  10. Cleaner plugin and old PFlow cluster skeleton

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    ae36912 View commit details
    Browse the repository at this point in the history

  11. Finish implementation of old pf clusterizer

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    f6e4099 View commit details
    Browse the repository at this point in the history

  12. implement spike and double spike cleaning module

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    911da7b View commit details
    Browse the repository at this point in the history

  13. regular PF cluster position calculator

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    6d24111 View commit details
    Browse the repository at this point in the history

  14. ECAL position calc with depth correction

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    b0b0892 View commit details
    Browse the repository at this point in the history

  15. complete implementation of new PF cluster scheme

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    8207ba7 View commit details
    Browse the repository at this point in the history

  16. functions and gives equivalent results to old clustering on electron … 

    …gun, 2-4 times faster

recreated strange behavior of position calculations for ECAL in PFClusterAlgo
    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    cf271d6 View commit details
    Browse the repository at this point in the history

  17. agrees with PFClusterAlgo to 1e-5 tolerance. 

    Had to place numerical stability requirements
in both new and old pieces of algoritms to
regularize the behavior of the position fit.
    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    5053675 View commit details
    Browse the repository at this point in the history

  18. clean up python config, add in energy corrector plugin

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    5af3b83 View commit details
    Browse the repository at this point in the history

  19. add aprticle flow clusters for PS, generate full ECAL PFCluster seque… 

    …nce with corrections

get rid of n-square algorithm in loop
optimize sorting loop
    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    e851a4a View commit details
    Browse the repository at this point in the history

  20. RBX and HPD cleaner

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    5c1654d View commit details
    Browse the repository at this point in the history

  21. add remaining calorimeter clusterizers, all agree well 

    get rid of old clustering and drop in new sequence
    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    579e081 View commit details
    Browse the repository at this point in the history

  22. normalize fraction calculations to rechit thresholds. 

    In the case of the seeds it's not necessary.
    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    2663420 View commit details
    Browse the repository at this point in the history

  23. Clean up naming conventions to make them more meaningful

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    2a36df7 View commit details
    Browse the repository at this point in the history

  24. make numerical protection strength configurable, sync shower sigma fo… 

    …r PS clusters with stability branch
    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    2737513 View commit details
    Browse the repository at this point in the history

  25. switch to vdt math library remove modules not used

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    cda746a View commit details
    Browse the repository at this point in the history

  26. further speed optimizations

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    f781c35 View commit details
    Browse the repository at this point in the history

  27. properly fill the CaloCluster hitsAndFractions vector

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    36db2f1 View commit details
    Browse the repository at this point in the history

  28. made memory access better

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    2f85b20 View commit details
    Browse the repository at this point in the history

  29. Adding ECAL 3D

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    c2f83e1 View commit details
    Browse the repository at this point in the history

  30. Added 3D ECAL Clustering

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    7394309 View commit details
    Browse the repository at this point in the history

  31. adding cfg files for ECAL 3D

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    01f762b View commit details
    Browse the repository at this point in the history

  32. adding timing clusterizer in py

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    abc7673 View commit details
    Browse the repository at this point in the history

  33. speed up from not having to call PFLayer 8 billion times

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    be97867 View commit details
    Browse the repository at this point in the history

  34. improve PF RecHit producer timing, massive gains for larger rechit co… 

    …llections
    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    cb25ecf View commit details
    Browse the repository at this point in the history

  35. updates to cluster comparator

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    6d82908 View commit details
    Browse the repository at this point in the history

  36. factor config into each cluster type

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    b6be100 View commit details
    Browse the repository at this point in the history

  37. rejigger locations of plugin defs

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    f5ceff0 View commit details
    Browse the repository at this point in the history

  38. remove PFRootEvent... for now...

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    1708511 View commit details
    Browse the repository at this point in the history

  39. update HLT config for FAMOS and dual navigators

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    54d4555 View commit details
    Browse the repository at this point in the history

  40. expand use of local max seed finder to > 2D

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    5973f2c View commit details
    Browse the repository at this point in the history

  41. naming cleanup

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    b5ce95b View commit details
    Browse the repository at this point in the history

  42. apply binary search to NavigatorWithTime

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    cabb6df View commit details
    Browse the repository at this point in the history

  43. add plots to cluster comparator

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    81f6c36 View commit details
    Browse the repository at this point in the history

  44. Adding better timing info

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    e8284ba View commit details
    Browse the repository at this point in the history

  45. Caluculating time average using time resolution

    @bachtis @Martin-Grunewald
    bachtis authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    25b191b View commit details
    Browse the repository at this point in the history

  46. put time and layer in the appropriate place

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    e1b4a20 View commit details
    Browse the repository at this point in the history

  47. add in iorule to make PFRecHit backwards compatible -- NOTE the read-… 

    …in old RecHits will not be usable for clustering, but PFRecHits are transient anyway
    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    ea7faa4 View commit details
    Browse the repository at this point in the history

  48. remove deprecated parameters from configuration

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    a70aa7a View commit details
    Browse the repository at this point in the history

  49. only use PS adjusted radiation length when we are under the PS (which… 

    … ends at |eta| == 2.6!!!)
    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    0bf0fcf View commit details
    Browse the repository at this point in the history

  50. factorize python config for confDB

    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    5074cbd View commit details
    Browse the repository at this point in the history

  51. use empty parameter sets to indicate components not run in PFClusterP… 

    …roducer, HLT compatibility
    @lgray @Martin-Grunewald
    lgray authored and Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    523a30d View commit details
    Browse the repository at this point in the history

  52. PF migration (2730) in HLT via ConfDB

    @Martin-Grunewald
    Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    9b63170 View commit details
    Browse the repository at this point in the history

  53. Fix InputTags of PF RecHit modules

    @Martin-Grunewald
    Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    a3d73b5 View commit details
    Browse the repository at this point in the history

  54. More InputTag fixes

    @Martin-Grunewald
    Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    f161dc6 View commit details
    Browse the repository at this point in the history

  55. Reorder PF modules

    @Martin-Grunewald
    Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    166c993 View commit details
    Browse the repository at this point in the history

  56. More reordering

    @Martin-Grunewald
    Martin-Grunewald committed Mar 11, 2014
    Copy the full SHA
    9adf54d View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2014

  1. Fixes

    @bachtis @lgray
    bachtis authored and lgray committed Mar 12, 2014
    Copy the full SHA
    a91b469 View commit details
    Browse the repository at this point in the history

  2. Making a PFCluster with timing cut sequence

    @bachtis @lgray
    bachtis authored and lgray committed Mar 12, 2014
    Copy the full SHA
    547583e View commit details
    Browse the repository at this point in the history

  3. implemented comments from code review

    @lgray
    lgray committed Mar 12, 2014
    Copy the full SHA
    17e91d7 View commit details
    Browse the repository at this point in the history

  4. Adding HCAL Severity Cut in HO

    @bachtis @lgray
    bachtis authored and lgray committed Mar 12, 2014
    Copy the full SHA
    b5355a6 View commit details
    Browse the repository at this point in the history

  5. fix

    @bachtis @lgray
    bachtis authored and lgray committed Mar 12, 2014
    Copy the full SHA
    14f8a81 View commit details
    Browse the repository at this point in the history