[Backport] Fix BoostedDoubleSVProd crashing with nan/inf daughters

[andrzejnovak]

PR description:

Backport of #27238

[cmsbuild]

A new Pull Request was created by @andrzejnovak (Andrzej Novak) for CMSSW_10_6_X.

It involves the following packages:

RecoBTag/SecondaryVertex

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix BoostedDoubleSVProd crashing with nan/inf daughters #27238

[perrotta]

backport of #27238

[perrotta]

-1
Please address first the issues raised in the master version of this pull request, and then come back to this backport

[perrotta]

@andrzejnovak please update with the LogWarning's, as in the master version of this PR

[cmsbuild]

Pull request #27328 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1283/console Started: 2019/07/01 15:11

[cmsbuild]

+1
Tested at: 7dd48e4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6145f7/1283/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6145f7/1283/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3208236
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3207899
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• Correct backport of Fix BoostedDoubleSVProd crashing with nan/inf daughters #27238
• The fix provides a rescue from nan/inf values in daughter jets parameters, and will allow nanoAOD and analysis to continue running even in presence of such pathological cases
• A fix for the wrong jet parameters has to be provided independently: issue Fix jets with crazy momenta in miniAOD #27374 has been opened for that
• Jenkins tests pass and show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1