Running code-format for reconstruction #27344

cmsbuild · 2019-06-26T10:21:00Z

Applying code-format for CMSSW category reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/427//console

cms-bot has successfully run the following:

scram build code-checks-all
scram build code-format-all
scram build

cmsbuild · 2019-06-26T10:21:01Z

please test

cmsbuild · 2019-06-26T10:21:30Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-26T10:30:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27344/10608

This PR adds an extra 8KB to repository

cmsbuild · 2019-06-26T10:30:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1167/console Started: 2019/06/26 12:31

cmsbuild · 2019-06-26T10:30:59Z

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaMCTools
RecoEgamma/EgammaPhotonProducers
RecoLocalTracker/SiStripRecHitConverter
RecoPixelVertexing/PixelTriplets
RecoTracker/TkSeedGenerator

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @Sam-Harper, @makortel, @threus, @jainshilpi, @pieterdavid, @GiacomoSguazzoni, @gbenelli, @rovere, @lgray, @varuns23, @alesaggio, @ebrondol, @felicepantaleo, @mschrode, @gpetruc, @mmusich, @VinInn, @yduhm, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-06-26T13:00:08Z

+1
Tested at: 485ac1c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc5507/1167/summary.html

cmsbuild · 2019-06-26T13:00:13Z

Comparison job queued.

cmsbuild · 2019-06-26T15:17:59Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc5507/1167/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3254598
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3254263
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2019-06-26T15:27:35Z

RecoEgamma/EgammaPhotonProducers/src/ConversionProducer.cc

+  dEtacutForSCmatching_ = iConfig.getParameter<double>(
+      "dEtacutForSCmatching");  // dEta between conversion momentum direction and SC position
+  dPhicutForSCmatching_ = iConfig.getParameter<double>(
+      "dPhicutForSCmatching");  // dPhi between conversion momentum direction and SC position


comment line break issues

slava77 · 2019-06-26T15:33:22Z

RecoEgamma/EgammaPhotonProducers/src/TrackProducerWithSCAssociation.cc

+  assoc_token = consumes<reco::TrackCandidateCaloClusterPtrAssociation>(
+      edm::InputTag(conversionTrackCandidateProducer_, trackCSuperClusterAssociationCollection_));
+  measurementTrkToken_ = consumes<MeasurementTrackerEvent>(
+      edm::InputTag("MeasurementTrackerEvent"));  //hardcoded because the original was and no time to fix (sigh)


comment line break issue

slava77 · 2019-06-26T15:34:54Z

RecoPixelVertexing/PixelTriplets/interface/IntermediateHitTriplets.h

-  std::vector<OrderedHitTriplet> hitTriplets_;   /// Container of hit triplets for all layer triplets and regions
+  std::vector<RegionIndex> regions_;  /// Container of regions, each element has indices pointing to layerTriplets_
+  std::vector<PLayerHitTriplets>
+      layerTriplets_;  /// Container of layer triplets, each element has indices pointing to hitTriplets_


comment line break issue

slava77 · 2019-06-27T05:18:20Z

RecoTracker/TkSeedGenerator/plugins/MultiHitGeneratorFromChi2.cc

+      extraZKDBox(
+          cfg.getParameter<double>("extraZKDBox")),  //extra windown in Z when building the KDTree box (used in barrel)
+      extraRKDBox(
+          cfg.getParameter<double>("extraRKDBox")),  //extra windown in R when building the KDTree box (used in endcap)


here and a bit below we have some comment-related line break issues

slava77 · 2019-06-27T05:22:19Z

+1

for #27344 485ac1c

technical
jenkins tests pass

Several issues reported in
#27344 (review)
can be addressed in a separate PR

cmsbuild · 2019-06-27T05:23:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-06-27T08:27:16Z

+1

Clang-Format

485ac1c

cmsbuild added this to the CMSSW_11_0_X milestone Jun 26, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 26, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 26, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 26, 2019

cmsbuild added tests-approved and removed tests-started labels Jun 26, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 26, 2019

slava77 reviewed Jun 27, 2019

View reviewed changes

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jun 27, 2019

cmsbuild added orp-approved and removed orp-pending labels Jun 27, 2019

cmsbuild merged commit 1bbf498 into master Jun 27, 2019

smuzaffar deleted the code-format-reconstruction-78335e branch July 4, 2019 07:53

slava77 mentioned this pull request Dec 9, 2020

Add low-pT electrons to MINIAOD, update ID, improve end user experience (back port of 31220) #32372

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Running code-format for reconstruction #27344

Running code-format for reconstruction #27344

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019 •

edited

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

slava77 Jun 26, 2019

slava77 Jun 26, 2019

slava77 Jun 26, 2019

slava77 Jun 27, 2019

slava77 commented Jun 27, 2019

cmsbuild commented Jun 27, 2019

fabiocos commented Jun 27, 2019

Running code-format for reconstruction #27344

Running code-format for reconstruction #27344

Conversation

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019 • edited

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

cmsbuild commented Jun 26, 2019

slava77 Jun 26, 2019

Choose a reason for hiding this comment

slava77 Jun 26, 2019

Choose a reason for hiding this comment

slava77 Jun 26, 2019

Choose a reason for hiding this comment

slava77 Jun 27, 2019

Choose a reason for hiding this comment

slava77 commented Jun 27, 2019

cmsbuild commented Jun 27, 2019

fabiocos commented Jun 27, 2019

cmsbuild commented Jun 26, 2019 •

edited