Bug fixes in TICL

[rovere]

PR description:

During the review process, 2 bugs were introduced. This PR fixes them.

PR validation:

runTheMatrix.py -l limited -i all -j 4 -t 12
(still running)

[rovere]

type bug-fix

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27382/10657

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

RecoHGCal/TICL

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

A case like this is perhaps a motivation to put TICL in the standard workflow soon.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1213/console Started: 2019/06/27 16:46

[rovere]

@slava77 I cannot agree more. I'll put that on top of my todo list.
Apologies.

[cmsbuild]

+1
Tested at: dd28059
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8b25d/1213/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8b25d/1213/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3255670
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3255334
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[kpedro88]

+upgrade

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #27392
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1240/console Started: 2019/06/28 11:01

[slava77]

+1

for #27382 dd28059

• code changes are in line with being bugfixes for the changes made in TICL Reorganization, reloaded. #27160
• jenkins tests pass and comparisons with the baseline show no differences in the standard set of tests where TICL is not included in the running workflows
• a test with Closeby Workflows with TICL Variations in runTheMatrix #27392, which introduces wf 29093.52 with TICL enabled, passed OK.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: dd28059
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-220b97/1240/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-220b97/1240/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-220b97/29093.52_CloseByParticleGun+CloseByParticle_Photon_ERZRanges_2023D41_GenSimHLBeamSpotFull+DigiFullTrigger_2023D41+RecoFullGlobal_TICLFullReco_2023D41+HARVESTFullGlobal_2023D41

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3255670
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3255335
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

+1