Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper use of clustersToSkip InputTag #2739

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Mar 6, 2014

Setting this input tag into the GroupedCkfTrajectoryBuilderESProducers will have no effect and is, de facto, misleading. No changes are expected in any distribution. This pull will silent the errors recently reported while running the reco sequence.

…uilderESProducer, since this will effectively not be used
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2014

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_1_X.

Fix improper use of clustersToSkip InputTag

It involves the following packages:

RecoTracker/IterativeTracking

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @gpetruc, @GiacomoSguazzoni, @cerati this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@rovere
Copy link
Contributor Author

rovere commented Mar 6, 2014

FYI @thspeer
I guess this pull will conflict with similar changes you have locally done in your branch. My idea is that you can rebase your work once this PR will be integrated. I hope this will not cause too much troubles.

Ciao.

@slava77
Copy link
Contributor

slava77 commented Mar 6, 2014

Hi Marco,

For the future reference, please add the error message and a link if available to where it was reported.
Thank you.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2014

@rovere
Copy link
Contributor Author

rovere commented Mar 6, 2014

Ciao @slava77 ,
for sure I will in future. The error messages are these[1] and have been reported to tracking POGs via private emails, hence I have no link to attach to this PR.

Ciao,
Marco.

[1]

ERROR: 24BaseCkfTrajectoryBuilder with label
detachedTripletStepTrajectoryBuilder has a clustersToSkip parameter set
ERROR: 24BaseCkfTrajectoryBuilder with label initialStepTrajectoryBuilder
has a clustersToSkip parameter set

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@slava77
Copy link
Contributor

slava77 commented Mar 10, 2014

+1

for #2739 49cffe8
no regressions based on jenkins

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 11, 2014
…TrajectoryBuilderESProducer

RecoTracker/IterativeTracking -- Fix improper use of clustersToSkip InputTag
@nclopezo nclopezo merged commit a7c8a20 into cms-sw:CMSSW_7_1_X Mar 11, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants