Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small update of tauID python tool (10_6_X) #27398

Merged

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Jun 28, 2019

PR description:

Small change in tauID python tool which allows to add new tauIDs to an already existing PATTauIDEmbedder module.

PR validation:

Validated with MiniAOD workflow.
Differences are not expected.

if this PR is a backport please specify the original PR:

Backport of #27397

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 28, 2019

A new Pull Request was created by @mbluj for CMSSW_10_6_X.

It involves the following packages:

RecoTauTag/RecoTau

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 28, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 28, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1248/console Started: 2019/06/28 14:12

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38db72/1248/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3208236
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3207900
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 1, 2019

backport of #27397

@slava77
Copy link
Contributor

slava77 commented Jul 1, 2019

+1

for #27398 fd4728f

  • the backport is correct (the same py code changes as in the master version); this does not affect [yet] the standard workflows
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 2, 2019

+1

@cmsbuild cmsbuild merged commit 22573f3 into cms-sw:CMSSW_10_6_X Jul 2, 2019
@mbluj mbluj deleted the CMSSW_10_6_X_tau-pog_tauIdToolFix branch October 10, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants