-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove calo tau code and data formats #27400
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27400/10687
|
A new Pull Request was created by @swozniewski for master. It involves the following packages: DQM/Physics @perrotta, @cmsbuild, @andrius-k, @Dr15Jones, @kmaeshima, @fwyzard, @schneiml, @cmsdoxy, @Martin-Grunewald, @alja, @jfernan2, @fioriNTU, @slava77, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
please test |
+1 |
-1 Tested at: b9e2152 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/PseudoTopProducer.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/StGenEventReco.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/StEvtSolutionMaker.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/TtSemiEvtSolutionMaker.cc /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/TtDilepEvtSolutionMaker.cc: In member function 'virtual void TtDilepEvtSolutionMaker::produce(edm::Event&, const edm::EventSetup&)': /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/TtDilepEvtSolutionMaker.cc:193:21: error: 'const class pat::Tau' has no member named 'isCaloTau'; did you mean 'isPFTau'? if ((*tau)->isCaloTau() && (*tau)->isolationTracksPtSum() < iso) { ^~~~~~~~~ isPFTau /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/TtDilepEvtSolutionMaker.cc:193:44: error: 'const class pat::Tau' has no member named 'isolationTracksPtSum'; did you mean 'isolationTracks'? if ((*tau)->isCaloTau() && (*tau)->isolationTracksPtSum() < iso) { The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
+1 |
+1 |
code-checks |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27400/10785
|
+1 |
merge |
PR description:
This PR removes remaining code of Calo Taus, which are not used anymore. The purpose is basically clean up. In a previous PR #26816 some parts like reconstruction have already been removed.
All data formats specific to Calo Taus are removed. The content of some AOD productions from 2015 to 2018 was checked and did not contain these formats. The corresponding content dumps can be inspected in /afs/cern.ch/user/s/swozniew/public/TauPOG/EvtContentChecks. Therefore, no compatibility problems with existing official AODs are expected.
Furthermore the removal of the data formats was announced in https://indico.cern.ch/event/829640/contributions/3473231/attachments/1869301/3075263/StatusReportTauRECOJune.pdf, asking for objections concerning private productions but without responses so far.
In order to completely remove Calo Tau code, some member functions and the attribute caloSpecific_ of pat::tau were removed requiring a new class version 19 for pat::tau.
Some unused includes and typedefs from HLTrigger are removed. Also some code in DQM, DQMOffline, Fireworks that should be unused is removed. But please let know if related experts should be contacted.
This PR is not supposed to cause changes in physics results.
PR validation:
compiles and passes limited Matrix tests apart from some DAS errors