Remove calo tau code and data formats #27400

swozniewski · 2019-06-28T14:33:00Z

PR description:

This PR removes remaining code of Calo Taus, which are not used anymore. The purpose is basically clean up. In a previous PR #26816 some parts like reconstruction have already been removed.

All data formats specific to Calo Taus are removed. The content of some AOD productions from 2015 to 2018 was checked and did not contain these formats. The corresponding content dumps can be inspected in /afs/cern.ch/user/s/swozniew/public/TauPOG/EvtContentChecks. Therefore, no compatibility problems with existing official AODs are expected.
Furthermore the removal of the data formats was announced in https://indico.cern.ch/event/829640/contributions/3473231/attachments/1869301/3075263/StatusReportTauRECOJune.pdf, asking for objections concerning private productions but without responses so far.

In order to completely remove Calo Tau code, some member functions and the attribute caloSpecific_ of pat::tau were removed requiring a new class version 19 for pat::tau.

Some unused includes and typedefs from HLTrigger are removed. Also some code in DQM, DQMOffline, Fireworks that should be unused is removed. But please let know if related experts should be contacted.

This PR is not supposed to cause changes in physics results.

PR validation:

compiles and passes limited Matrix tests apart from some DAS errors

cmsbuild · 2019-06-28T14:33:36Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-28T14:41:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27400/10687

This PR adds an extra 104KB to repository

cmsbuild · 2019-06-28T14:42:04Z

A new Pull Request was created by @swozniewski for master.

It involves the following packages:

DQM/Physics
DQMOffline/Trigger
DataFormats/PatCandidates
DataFormats/TauReco
Documentation/DataFormats
Fireworks/Calo
HLTrigger/HLTfilters
PhysicsTools/PatAlgos
RecoTauTag/Configuration
RecoTauTag/RecoTau
Validation/RecoTau

@perrotta, @cmsbuild, @andrius-k, @Dr15Jones, @kmaeshima, @fwyzard, @schneiml, @cmsdoxy, @Martin-Grunewald, @alja, @jfernan2, @fioriNTU, @slava77, @santocch can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @hatakeyamak, @rappoccio, @Martin-Grunewald, @peruzzim, @seemasharmafnal, @mmarionncern, @alja, @ahinzmann, @smoortga, @acaudron, @jhgoh, @jdolen, @JyothsnaKomaragiri, @drkovalskyi, @ferencek, @trocino, @rociovilar, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mtosi, @clelange, @HeinerTholen, @HuguesBrun, @battibass, @calderona, @mverzett, @cbernet, @gpetruc, @mariadalfonso, @pvmulder, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2019-06-28T15:01:20Z

please test

cmsbuild · 2019-06-28T15:01:49Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1252/console Started: 2019/06/28 17:02

Martin-Grunewald · 2019-06-28T15:02:45Z

please test

alja · 2019-06-28T16:56:12Z

+1

cmsbuild · 2019-06-28T19:32:24Z

-1

Tested at: b9e2152

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Running code-format for analysis-reconstruction #27358 @cms-sw: Running code-format for analysis-reconstruction
Avoid dereferencing nullptr in propagate_const #27389 @Dr15Jones: Avoid dereferencing nullptr in propagate_const

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-842180/1252/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-842180/1252/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-842180/1252/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found compilation error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/PseudoTopProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/StGenEventReco.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/StEvtSolutionMaker.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/TtSemiEvtSolutionMaker.cc 
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/TtDilepEvtSolutionMaker.cc: In member function 'virtual void TtDilepEvtSolutionMaker::produce(edm::Event&, const edm::EventSetup&)':
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/TtDilepEvtSolutionMaker.cc:193:21: error: 'const class pat::Tau' has no member named 'isCaloTau'; did you mean 'isPFTau'?
         if ((*tau)->isCaloTau() && (*tau)->isolationTracksPtSum() < iso) {
                     ^~~~~~~~~
                     isPFTau
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-27-2300/src/TopQuarkAnalysis/TopEventProducers/src/TtDilepEvtSolutionMaker.cc:193:44: error: 'const class pat::Tau' has no member named 'isolationTracksPtSum'; did you mean 'isolationTracks'?
         if ((*tau)->isCaloTau() && (*tau)->isolationTracksPtSum() < iso) {

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Running code-format for analysis-reconstruction #27358 @cms-sw: Running code-format for analysis-reconstruction
Avoid dereferencing nullptr in propagate_const #27389 @Dr15Jones: Avoid dereferencing nullptr in propagate_const

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-842180/1252/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-842180/1252/git-merge-result

cmsbuild · 2019-06-28T19:32:26Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2019-07-04T17:59:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-842180/1323/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3160399
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3160064
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

perrotta · 2019-07-05T05:51:48Z

+1

Technical PR that removes calo tau modules and all references to them
- Code changes are in line with the PR description
- CaloTau's were not used in recent productions (from 2015, see PR description) and the DataFormat changes don't affect possible analysis code that read them
Jenkins tests pass and comparisons with the baseline show no differences

Martin-Grunewald · 2019-07-05T07:32:34Z

+1

jfernan2 · 2019-07-05T07:40:19Z

+1

santocch · 2019-07-05T09:28:56Z

+1

fabiocos · 2019-07-09T08:45:41Z

@alja @cmsdoxy this PR looks ok to me, and affects your area in a limited way. Please check it anyway, I will integrated it

fabiocos · 2019-07-09T08:46:01Z

code-checks

cmsbuild · 2019-07-09T08:46:14Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-09T08:54:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27400/10785

This PR adds an extra 108KB to repository

fabiocos · 2019-07-09T08:59:56Z

+1

fabiocos · 2019-07-09T17:47:31Z

merge

Sebastian Wozniewski added 2 commits June 28, 2019 15:17

remove remaining CaloTau code apart from data format

92b5294

remove CaloTau data formats

b9e2152

cmsbuild added this to the CMSSW_11_0_X milestone Jun 28, 2019

cmsbuild added analysis-pending code-checks-pending comparison-pending docs-pending dqm-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending visualization-pending labels Jun 28, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 28, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 28, 2019

cmsbuild added visualization-approved and removed visualization-pending labels Jun 28, 2019

cmsbuild removed the comparison-pending label Jun 28, 2019

cmsbuild added the tests-approved label Jul 4, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 4, 2019

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 5, 2019

cmsbuild added hlt-approved and removed hlt-pending labels Jul 5, 2019

cmsbuild added dqm-approved and removed dqm-pending labels Jul 5, 2019

cmsbuild added analysis-approved and removed analysis-pending labels Jul 5, 2019

cmsbuild added code-checks-pending and removed code-checks-approved labels Jul 9, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 9, 2019

cmsbuild added orp-approved and removed orp-pending labels Jul 9, 2019

cmsbuild merged commit 3024fbc into cms-sw:master Jul 9, 2019

swozniewski deleted the remove_calo_tau_code branch June 19, 2020 13:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove calo tau code and data formats #27400

Remove calo tau code and data formats #27400

swozniewski commented Jun 28, 2019

cmsbuild commented Jun 28, 2019

cmsbuild commented Jun 28, 2019

cmsbuild commented Jun 28, 2019

perrotta commented Jun 28, 2019

cmsbuild commented Jun 28, 2019 •

edited

Martin-Grunewald commented Jun 28, 2019

alja commented Jun 28, 2019

cmsbuild commented Jun 28, 2019

cmsbuild commented Jun 28, 2019

cmsbuild commented Jul 4, 2019

perrotta commented Jul 5, 2019

Martin-Grunewald commented Jul 5, 2019

jfernan2 commented Jul 5, 2019

santocch commented Jul 5, 2019

fabiocos commented Jul 9, 2019

fabiocos commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

fabiocos commented Jul 9, 2019

fabiocos commented Jul 9, 2019

Remove calo tau code and data formats #27400

Remove calo tau code and data formats #27400

Conversation

swozniewski commented Jun 28, 2019

PR description:

PR validation:

cmsbuild commented Jun 28, 2019

cmsbuild commented Jun 28, 2019

cmsbuild commented Jun 28, 2019

perrotta commented Jun 28, 2019

cmsbuild commented Jun 28, 2019 • edited

Martin-Grunewald commented Jun 28, 2019

alja commented Jun 28, 2019

cmsbuild commented Jun 28, 2019

cmsbuild commented Jun 28, 2019

cmsbuild commented Jul 4, 2019

perrotta commented Jul 5, 2019

Martin-Grunewald commented Jul 5, 2019

jfernan2 commented Jul 5, 2019

santocch commented Jul 5, 2019

fabiocos commented Jul 9, 2019

fabiocos commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

fabiocos commented Jul 9, 2019

fabiocos commented Jul 9, 2019

cmsbuild commented Jun 28, 2019 •

edited