Fixed missing link in DQM/SiPixelPhase1Common

[Dr15Jones]

PR description:

Need to link with DataFormats/TrackerRecHit2D so UBSAN works.

PR validation:

Compiles and links using the CMSSW_11_0_UBSAN_X_2019-06-28-2300 IB.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27407/10700

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DQM/SiPixelPhase1Common

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @jandrea this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1264/console Started: 2019/06/29 15:19

[cmsbuild]

+1
Tested at: 4cc05a1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c0d29/1264/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c0d29/1264/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3290686
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3290350
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

+1

[fabiocos]

merge

@jfernan2 @andrius-k the update looks technical and straightforward

[schneiml]

@fabiocos @Dr15Jones I am mildly surprised by this, the idea was that all the tracking-related things are isolated in DQM/SiPixelPhase1Track. But I guess the dependency does not really cause any harm and there is not much point trying to enforce the separation.

So, fine with me, even though things where planned to not need that.

[Dr15Jones]

@schneiml I didn't add the dependency, it was their before:

https://github.com/cms-sw/cmssw/blob/master/DQM/SiPixelPhase1Common/interface/SiPixelCoordinates.h#L29

All I did was tell the linker about the dependency (which was needed to allow UBSAN to work). It only happened to work before because only inlined functions were being used by the code in SiPixelPhase1Common.

[schneiml]

@Dr15Jones ah, now I also see where this is used. As said, I don't think there is any problem with this dependency (and we should totally have it if it is used), I was just surprised since the code was originally split with the idea of avoiding such dependencies.

[jfernan2]

+1
just for the records...

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.