Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove localDensity from the EventContent for HGCAL #27418

Merged
merged 2 commits into from Jul 9, 2019
Merged

Remove localDensity from the EventContent for HGCAL #27418

merged 2 commits into from Jul 9, 2019

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Jul 1, 2019

PR description:

Drop the local density map used internally by the CLUE algorithm from the EventContent.

PR validation:

Tested with Phase2 workflows in runTheMatrix.

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Jul 1, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27418/10715

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2019

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

RecoLocalCalo/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jul 1, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1285/console Started: 2019/07/01 15:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2019

+1
Tested at: ea7e40f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38c23e/1285/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38c23e/1285/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3290686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3290350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77
slava77 reviewed Jul 2, 2019
View reviewed changes
RecoLocalCalo/Configuration/python/RecoLocalCalo_EventContent_cff.py Outdated
'keep *_hgcalMultiClusters_*_*',
'keep *_iterHGCalMultiClusters_*_*'] )
# don't modify AOD for HGCal yet, need "reduced" rechits collection first (i.e. requires reconstruction)
phase2_hgcal.toModify( RecoLocalCaloAOD, outputCommands = RecoLocalCaloAOD.outputCommands + ['keep *_HGCalRecHit_*_*','keep *_hgcalLayerClusters_*_*'] )
phase2_hgcal.toModify( RecoLocalCaloAOD, outputCommands = RecoLocalCaloAOD.outputCommands + ['keep *_HGCalRecHit_*_*','keep *_hgcalLayerClusters_*_*','drop DetIdfloatstdmap_hgcalLayerClusters_*_*'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some linebreaks here so that this long line fits on the screen (as multiple lines)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rovere
ping
in case this got lost

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27418/10774

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

Pull request #27418 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2019

@cmsbuild please test workflow 29093.52

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1359/console Started: 2019/07/08 15:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

+1
Tested at: 4054a82
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38c23e/1359/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38c23e/1359/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-38c23e/29093.52_CloseByParticleGun+CloseByParticle_Photon_ERZRanges_2023D41_GenSimHLBeamSpotFull+DigiFullTrigger_2023D41+RecoFullGlobal_TICLFullReco_2023D41+HARVESTFullGlobal_2023D41

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3160399
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3160064
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 9, 2019

+1

for #27418 4054a82

  • code changes are in line with the PR description and the follow up review
  • jenkins tests pass and comparisons with the baseline show no differences (the event content for phase-2 workflows is not analyzed)
  • (semi)random check in the AODSIM output of the L1TDR production L1T-PhaseIITDRSpring19DR-00042 shows that DetIdfloatstdmap_hgcalLayerClusters_ takes 7.5 MiB per event out of a total of 27 MiB/event. So, this is a rather welcome addition/reduction.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 9, 2019

+1

@cmsbuild cmsbuild merged commit 422d6f2 into cms-sw:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slava77 slava77 slava77 left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rovere @cmsbuild @perrotta @slava77 @fabiocos