Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCC9] fix warning about initializing base class in copy constructor #27421

Merged
merged 3 commits into from Jul 3, 2019
Merged

[GCC9] fix warning about initializing base class in copy constructor #27421

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5d5592
[GCC9] fix warning about initializing base class in copy constructor
smuzaffar Jul 2, 2019
4a9f2d5
code-format
smuzaffar Jul 2, 2019
0f00f19
initialize base classes in move constructor
smuzaffar Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions DataFormats/GeometrySurface/interface/Surface.h
View file
Open in desktop
Expand Up @@ -56,10 +56,16 @@ class Surface : public ReferenceCountedInConditions, public GloballyPositioned<f
: Base(pos, rot), theMediumProperties(mp), theBounds(bounds) {}

Surface(const Surface& iSurface)
: Base(iSurface), theMediumProperties(iSurface.theMediumProperties), theBounds(iSurface.theBounds) {}
: ReferenceCountedInConditions(iSurface),
Base(iSurface),
theMediumProperties(iSurface.theMediumProperties),
theBounds(iSurface.theBounds) {}

Surface(Surface&& iSurface)
: Base(iSurface), theMediumProperties(iSurface.theMediumProperties), theBounds(std::move(iSurface.theBounds)) {}
: ReferenceCountedInConditions(iSurface),
Base(iSurface),
theMediumProperties(iSurface.theMediumProperties),
theBounds(std::move(iSurface.theBounds)) {}

public:
/** Returns the side of the surface on which the point is.
Expand Down