make some internal globals const in TkBfield.cc #27422

slava77 · 2019-07-02T10:39:41Z

online edit; after a compile check

cmsbuild · 2019-07-02T10:40:09Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-02T10:45:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27422/10721

This PR adds an extra 12KB to repository

cmsbuild · 2019-07-02T10:46:15Z

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

MagneticField/ParametrizedEngine

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@namapane this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2019-07-02T10:47:59Z

@cmsbuild please test

cmsbuild · 2019-07-02T10:48:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1291/console Started: 2019/07/02 12:48

cmsbuild · 2019-07-02T12:44:12Z

+1
Tested at: ca0086b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88a0cf/1291/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Final global tags for 2017 UL reprocessing #27342 @christopheralanwest: Final global tags for 2017 UL reprocessing

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88a0cf/1291/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88a0cf/1291/git-merge-result

cmsbuild · 2019-07-02T12:44:15Z

Comparison job queued.

cmsbuild · 2019-07-02T15:20:40Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88a0cf/1291/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6871 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3290686
DQMHistoTests: Total failures: 9265
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3281081
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.012 KiB( 32 files compared)
DQMHistoSizes: changed ( 136.788 ): -0.012 KiB JetMET/SUSYDQM
Checked 137 log files, 14 edm output root files, 33 DQM output files

VinInn · 2019-07-03T06:29:55Z

MagneticField/ParametrizedEngine/src/TkBfield.cc

      4.90541f, 17.8768f, 2.02355f, 0.0210538f, 0.000321885f, 2.37511f, 0.00326725f, 2.07656f, 1.71879f};  // 2.0T-2G
-  BCylParam<float> fpar2{
+  const BCylParam<float> fpar2{


makes sense; done.

apparently clang disagrees

cmsbuild · 2019-07-03T08:51:43Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-03T08:57:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27422/10735

This PR adds an extra 12KB to repository

cmsbuild · 2019-07-03T08:57:38Z

Pull request #27422 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2019-07-03T09:05:43Z

@cmsbuild please test

cmsbuild · 2019-07-03T09:06:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1302/console Started: 2019/07/03 11:06

cmsbuild · 2019-07-03T10:25:44Z

+1
Tested at: cc0ab98
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88a0cf/1302/summary.html

cmsbuild · 2019-07-03T10:25:47Z

Comparison job queued.

cmsbuild · 2019-07-03T12:47:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88a0cf/1302/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3293487
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3293151
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2019-07-05T10:25:57Z

+1

for #27422 cc0ab98

technical

cmsbuild · 2019-07-05T10:26:25Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-07-05T15:35:58Z

+1

make some internal globals const in TkBfield.cc

ca0086b

cmsbuild added this to the CMSSW_11_0_X milestone Jul 2, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 2, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 2, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 2, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 2, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 2, 2019

VinInn reviewed Jul 3, 2019

View reviewed changes

constexpr

fafb66a

cmsbuild added code-checks-pending and removed code-checks-approved comparison-available tests-approved labels Jul 3, 2019

cmsbuild added code-checks-pending comparison-pending tests-pending and removed tests-rejected labels Jul 3, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 3, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 3, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 3, 2019

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jul 5, 2019

cmsbuild added orp-approved and removed orp-pending labels Jul 5, 2019

cmsbuild merged commit 55674c6 into cms-sw:master Jul 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make some internal globals const in TkBfield.cc #27422

make some internal globals const in TkBfield.cc #27422

slava77 commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

slava77 commented Jul 2, 2019

cmsbuild commented Jul 2, 2019 •

edited

cmsbuild commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

VinInn Jul 3, 2019

slava77 Jul 3, 2019

slava77 Jul 3, 2019

cmsbuild commented Jul 3, 2019

cmsbuild commented Jul 3, 2019

cmsbuild commented Jul 3, 2019

slava77 commented Jul 3, 2019

cmsbuild commented Jul 3, 2019 •

edited

cmsbuild commented Jul 3, 2019

cmsbuild commented Jul 3, 2019

cmsbuild commented Jul 3, 2019

slava77 commented Jul 5, 2019

cmsbuild commented Jul 5, 2019

fabiocos commented Jul 5, 2019

make some internal globals const in TkBfield.cc #27422

make some internal globals const in TkBfield.cc #27422

Conversation

slava77 commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

slava77 commented Jul 2, 2019

cmsbuild commented Jul 2, 2019 • edited

cmsbuild commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

VinInn Jul 3, 2019

Choose a reason for hiding this comment

slava77 Jul 3, 2019

Choose a reason for hiding this comment

slava77 Jul 3, 2019

Choose a reason for hiding this comment

cmsbuild commented Jul 3, 2019

cmsbuild commented Jul 3, 2019

cmsbuild commented Jul 3, 2019

slava77 commented Jul 3, 2019

cmsbuild commented Jul 3, 2019 • edited

cmsbuild commented Jul 3, 2019

cmsbuild commented Jul 3, 2019

cmsbuild commented Jul 3, 2019

slava77 commented Jul 5, 2019

cmsbuild commented Jul 5, 2019

fabiocos commented Jul 5, 2019

cmsbuild commented Jul 2, 2019 •

edited

cmsbuild commented Jul 3, 2019 •

edited